From: Kevin Wolf <kwolf@redhat.com>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: [Qemu-devel] Re: [PATCH v2] qemu-img: Initial progress printing support
Date: Thu, 31 Mar 2011 13:38:50 +0200 [thread overview]
Message-ID: <4D9467CA.9020306@redhat.com> (raw)
In-Reply-To: <4D946250.5010406@redhat.com>
Am 31.03.2011 13:15, schrieb Jes Sorensen:
> On 03/31/11 12:38, Kevin Wolf wrote:
>> Am 30.03.2011 14:16, schrieb Jes.Sorensen@redhat.com:
>>> From: Jes Sorensen <Jes.Sorensen@redhat.com>
>>>
>>> This adds the basic infrastructure for supporting progress output
>>> on the command line, as well as progress support for qemu-img commands
>>> 'rebase' and 'convert'.
>>>
>>> Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
>>
>> Thanks, applied to the block branch.
>>
>> I think we should consider turning the progress output on by default if
>> qemu-img is run from a terminal.
>
> Thanks!
>
> I have been a little reluctant to do this because it will break the ABI
> for tools running qemu-img from a GUI etc.
That's the reason for the "from a terminal" part. If we check for
isatty(), we should handle these cases just fine.
Kevin
next prev parent reply other threads:[~2011-03-31 11:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 12:16 [Qemu-devel] [PATCH v2] qemu-img: Initial progress printing support Jes.Sorensen
2011-03-30 12:27 ` Stefan Hajnoczi
2011-03-31 10:38 ` [Qemu-devel] " Kevin Wolf
2011-03-31 11:15 ` Jes Sorensen
2011-03-31 11:38 ` Kevin Wolf [this message]
2011-03-31 11:49 ` Stefan Hajnoczi
2011-04-01 13:41 ` Jes Sorensen
2011-04-01 14:58 ` Stefan Hajnoczi
2011-04-22 12:37 ` [Qemu-devel] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9467CA.9020306@redhat.com \
--to=kwolf@redhat.com \
--cc=Jes.Sorensen@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.