All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Cousson, Benoit" <b-cousson@ti.com>
To: "Coelho, Luciano" <coelho@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Kadiyala, Kishore" <kishore.kadiyala@ti.com>
Subject: Re: [PATCH 2.6.39] omap: board-4430sdp: revert hsmmc_info reordering
Date: Fri, 1 Apr 2011 09:18:30 +0200	[thread overview]
Message-ID: <4D957C46.9020402@ti.com> (raw)
In-Reply-To: <1301640748-17161-1-git-send-email-coelho@ti.com>

On 4/1/2011 8:52 AM, Coelho, Luciano wrote:
> The order in which the MMC cards are defined in the the 4430sdp board
> file seems to have been mistakenly reorderded as part of an unrelated
> patch.  In commit 0005ae73cfe44ee42d0be12a12cc82bf982f518e, where only
> the dev_name was supposed to be changed, the mmc order was changed as
> well.  This caused the external SD card reader not to be recognized,
> at least on Blaze.
>
> This patch reverts this change so that the external SD card is
> recognized again.
>
> Cc: Kishore Kadiyala<kishore.kadiyala@ti.com>
> Cc: Benoit Cousson<b-cousson@ti.com>
> Signed-off-by: Luciano Coelho<coelho@ti.com>
> ---
>
> I have started investigating the cause for this problem, because it
> seems to me that the value in the mmc element is what should matter,
> but it doesn't seem to be the case.  I believe there is a bug
> elsewhere, that causes the order of the array to matter, but I'm not
> very familiar with hsmmc and I don't have much time right now to delve
> into the problem, so I leave this to the omap people. ;) I can always
> help testing if necessary.

I was about to make the same comment. Why does the order matter since we 
have a .mmc field with that information? There is probably something 
broken behind that.

Regards,
Benoit

  parent reply	other threads:[~2011-04-01  7:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-01  6:52 [PATCH 2.6.39] omap: board-4430sdp: revert hsmmc_info reordering Luciano Coelho
2011-04-01  7:16 ` Kishore Kadiyala
2011-04-01  8:20   ` Luciano Coelho
2011-04-01 10:26     ` Kishore Kadiyala
2011-04-01 10:54       ` Luciano Coelho
2011-04-01  7:18 ` Cousson, Benoit [this message]
2011-04-01  8:24   ` Luciano Coelho
2011-04-01 11:37 ` Luciano Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D957C46.9020402@ti.com \
    --to=b-cousson@ti.com \
    --cc=coelho@ti.com \
    --cc=kishore.kadiyala@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.