From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] xen: fix reloc.S generation Date: Fri, 1 Apr 2011 14:50:10 +0200 Message-ID: <4D95CA02.5020504@amd.com> References: <201103311223.29863.Christoph.Egger@amd.com> <19860.51189.261926.539044@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <19860.51189.261926.539044@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: Keir, "xen-devel@lists.xensource.com" , Fraser List-Id: xen-devel@lists.xenproject.org On 03/31/11 20:29, Ian Jackson wrote: > Christoph Egger writes ("[Xen-devel] [PATCH] xen: fix reloc.S generation"): >> attached patch fixes generation of reloc.S and makes >> xen boot out-of-the box since c/s 19146. >> The output of AT&T UNIX and GNU od(1) are different. > > Which (if any) of these versions of od is correct ? The SuSv3 > specification of od is quite comprehensive so it should be possible to > contrive a rune which doesn't need subsequent seddery. Could you try > to do so ? http://pubs.opengroup.org/onlinepubs/009695399/utilities/od.html says "and the output from each of the transformations shall be separated by one or more s." So both AT&T UNIX and GNU od(1) behaviours are correct and we have to deal with that. => Please apply the patch to -unstable, 4.1-testing, 4.0-testing and 3.4-testing. Thanks, Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632