From: Iiro Valkonen <iiro.valkonen@atmel.com>
To: Joonyoung Shim <dofmind@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/2] Input: atmel_mxt_ts - Increase the wait times for backup and reset
Date: Fri, 01 Apr 2011 16:43:59 +0300 [thread overview]
Message-ID: <4D95D69F.6070107@atmel.com> (raw)
In-Reply-To: <AANLkTik2vokDJuUpX8KObztfcjCbH3O7s5XGN3weiubM@mail.gmail.com>
On 03/21/2011 02:11 PM, Joonyoung Shim wrote:
>> -#define MXT_BACKUP_TIME 25 /* msec */
>> -#define MXT_RESET_TIME 65 /* msec */
>> +#define MXT_BACKUP_TIME 270 /* msec */
>> +#define MXT_RESET_TIME 350 /* msec */
>
> I wonder mXT cycle time is alterable and if reset and backup time is desided
> by mXT cycle time, i think they can be used to variable.
>
I agree, waiting for 270 + 350 ms might be overkill. The correct way to do this would be
to wait for the chip to indicate it has completed the backup and reset. I will send a new
patch that implements this.
BR,
--
Iiro
prev parent reply other threads:[~2011-04-01 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 14:42 [PATCH 1/2] Input: atmel_mxt_ts - Increase the wait times for backup and reset Iiro Valkonen
2011-03-21 12:11 ` Joonyoung Shim
2011-04-01 13:43 ` Iiro Valkonen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D95D69F.6070107@atmel.com \
--to=iiro.valkonen@atmel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dofmind@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.