From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ppsw-51.csi.cam.ac.uk ([131.111.8.151]:47312 "EHLO ppsw-51.csi.cam.ac.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752709Ab1DAOiL (ORCPT ); Fri, 1 Apr 2011 10:38:11 -0400 Message-ID: <4D95E3AC.8020507@cam.ac.uk> Date: Fri, 01 Apr 2011 15:39:40 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: michael.hennerich@analog.com CC: linux-iio@vger.kernel.org, drivers@analog.com, device-drivers-devel@blackfin.uclinux.org Subject: Re: [PATCH 2/2] IIO: DAC: New driver for the AD5504 and AD55041 High Voltage DACs References: <1301666852-11078-1-git-send-email-michael.hennerich@analog.com> <1301666852-11078-2-git-send-email-michael.hennerich@analog.com> In-Reply-To: <1301666852-11078-2-git-send-email-michael.hennerich@analog.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 04/01/11 15:07, michael.hennerich@analog.com wrote: > From: Michael Hennerich > > Changes since V1: > > IIO: DAC: Apply review feedback from Jonathan > > Fix array size and declare const. > Fix reversed dacY_powerdown read back. > Use individual attribute groups instead of is_visible. > Fix event naming and add the _en file. The event code is wrong. It's a temperature event and the code should reflect that. Which removes the purpose of the previous patch.