From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=54141 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q5gMT-0008QC-EO
	for qemu-devel@nongnu.org; Fri, 01 Apr 2011 11:34:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1Q5gMI-0004aN-GH
	for qemu-devel@nongnu.org; Fri, 01 Apr 2011 11:33:59 -0400
Received: from e33.co.us.ibm.com ([32.97.110.151]:51354)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1Q5gMI-0004aD-BC
	for qemu-devel@nongnu.org; Fri, 01 Apr 2011 11:33:58 -0400
Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com
	[9.17.195.228])
	by e33.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p31FRBAt013297
	for <qemu-devel@nongnu.org>; Fri, 1 Apr 2011 09:27:11 -0600
Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85])
	by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP
	id p31FXl9N051760
	for <qemu-devel@nongnu.org>; Fri, 1 Apr 2011 09:33:48 -0600
Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1])
	by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id p31FXkbR010070
	for <qemu-devel@nongnu.org>; Fri, 1 Apr 2011 09:33:47 -0600
Message-ID: <4D95F059.70903@linux.vnet.ibm.com>
Date: Fri, 01 Apr 2011 10:33:45 -0500
From: Michael Roth <mdroth@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1301671255-27717-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1301671255-27717-3-git-send-email-mdroth@linux.vnet.ibm.com>
In-Reply-To: <1301671255-27717-3-git-send-email-mdroth@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/2] checkpatch.pl: make C99 comments a
	warning, not error
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

On 04/01/2011 10:20 AM, Michael Roth wrote:
> C99 comments are pretty heavilly used in QEMU, and don't violate
> anything mentioned in HACKING/CODING_STYLE. Make them warnings instead.
>
> Signed-off-by: Michael Roth<mdroth@linux.vnet.ibm.com>
> ---
>   scripts/checkpatch.pl |    2 +-
>   test.c                |    5 +++++
>   2 files changed, 6 insertions(+), 1 deletions(-)
>   create mode 100644 test.c
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 770d534..2aab4e9 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1799,7 +1799,7 @@ sub process {
>
>   # no C99 // comments
>   		if ($line =~ m{//}) {
> -			ERROR("do not use C99 // comments\n" . $herecurr);
> +			WARN("do not use C99 // comments\n" . $herecurr);
>   		}
>   		# Remove C99 comments.
>   		$line =~ s@//.*@@;
> diff --git a/test.c b/test.c
> new file mode 100644
> index 0000000..fe3b163
> --- /dev/null
> +++ b/test.c
> @@ -0,0 +1,5 @@
> +//stuff
> +static int blah(void)
> +{
> +    return 1;
> +}

Ugh, please ignore this test.c addition. Let me know if I should resend