From: Jonathan Cameron <jic23@cam.ac.uk>
To: "Hennerich, Michael" <Michael.Hennerich@analog.com>
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
Drivers <Drivers@analog.com>,
"device-drivers-devel@blackfin.uclinux.org"
<device-drivers-devel@blackfin.uclinux.org>
Subject: Re: [PATCH 2/2] IIO: DAC: New driver for the AD5504 and AD55041 High Voltage DACs
Date: Fri, 01 Apr 2011 16:34:54 +0100 [thread overview]
Message-ID: <4D95F09E.7060907@cam.ac.uk> (raw)
In-Reply-To: <544AC56F16B56944AEC3BD4E3D59177137545F0B3D@LIMKCMBX1.ad.analog.com>
On 04/01/11 16:00, Hennerich, Michael wrote:
> Jonathan Cameron wrote on 2011-04-01:
>> On 04/01/11 15:07, michael.hennerich@analog.com wrote:
>>> From: Michael Hennerich <michael.hennerich@analog.com>
>>>
>>> Changes since V1:
>>>
>>> IIO: DAC: Apply review feedback from Jonathan
>>>
>>> Fix array size and declare const.
>>> Fix reversed dacY_powerdown read back.
>>> Use individual attribute groups instead of is_visible.
>>> Fix event naming and add the _en file.
>> The event code is wrong. It's a temperature event and the code should
>> reflect that.
>>
>> Which removes the purpose of the previous patch.
>
> That's what I was trying to ask you before.
> So it should be IIO_EV_CLASS_TEMP?
Ah sorry, I got confused.
Yes, the event should definitely IIO_EV_CLASS_TEMP
prev parent reply other threads:[~2011-04-01 15:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 14:07 [PATCH 1/2] IIO: sysfs: add IIO_EV_CLASS_OUT michael.hennerich
2011-04-01 14:07 ` [PATCH 2/2] IIO: DAC: New driver for the AD5504 and AD55041 High Voltage DACs michael.hennerich
2011-04-01 14:39 ` Jonathan Cameron
2011-04-01 15:00 ` Hennerich, Michael
2011-04-01 15:34 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D95F09E.7060907@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=Drivers@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.