Re: [PATCH 5/14] megaraid_sas: Fix probe_one to clear MSI-X flags in kdump

[Tomas Henzl <thenzl@redhat.com>]

On 03/31/2011 08:50 PM, adam radford wrote:
> On Wed, Mar 30, 2011 at 5:30 AM, Tomas Henzl <thenzl@redhat.com> wrote:
>
>   
>> Hi Adam,
>> sorry I'm late, but this is still not applied I think.
>>     
> Yes, it is here:
>
> http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=66192dfe1e74eae31a76cfc36092dabdba1324e6
>
>   
>> The above #define are already defined in msi.h and pci_regs.h
>> I'd prefer to include those files instead of define the values.
>>
>>     
> msi_control_reg() macro is defined in drivers/pci/msi.h _not_
> include/linux/msi.h.
>
> Are you suggesting I try to include drivers/pci/msi.h ?
>   
That doesn't look that good, probably better would be to put the definition
to some other place. The patch is already accepted and the priority for me low...

The PCI_MSIX_FLAGS_ENABLE is defined in pci_regs.h this is included in linux/pci.h and this is included 
in megaraid_sas_base.c - I think the definition could be simply removed from your patch, isn't it so?
Again this is low priority I expect no immediate action from you :)

Tomas

> -Adam
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>