From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.chez-thomas.org (hermes.mlbassoc.com [64.234.241.98]) by mx1.pokylinux.org (Postfix) with ESMTP id 7B61C4C8032C for ; Sat, 2 Apr 2011 09:03:01 -0500 (CDT) Received: by mail.chez-thomas.org (Postfix, from userid 999) id 432BE16603EC; Sat, 2 Apr 2011 08:03:01 -0600 (MDT) X-Spam-Checker-Version: SpamAssassin 3.3.2-r929478 (2010-03-31) on hermes.chez-thomas.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=4.0 tests=ALL_TRUSTED,BAYES_00 autolearn=unavailable version=3.3.2-r929478 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by mail.chez-thomas.org (Postfix) with ESMTP id 8F2C716603EA; Sat, 2 Apr 2011 08:02:59 -0600 (MDT) Message-ID: <4D972C93.4030501@mlbassoc.com> Date: Sat, 02 Apr 2011 08:02:59 -0600 From: Gary Thomas User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc13 Thunderbird/3.1.7 MIME-Version: 1.0 To: Yu Ke References: <4D971BF9.7050707@intel.com> <4D971D4C.60109@mlbassoc.com> <4D972642.80400@intel.com> In-Reply-To: <4D972642.80400@intel.com> Cc: poky@yoctoproject.org Subject: Re: How to append inc file X-BeenThere: poky@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Poky build system developer discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Apr 2011 14:03:02 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 04/02/2011 07:36 AM, Yu Ke wrote: > on 2011-4-2 20:57, Gary Thomas wrote: >> On 04/02/2011 06:52 AM, Yu Ke wrote: >>> Hi, >>> >>> bbappend file can be used to append content to bb file, and it is very >>> useful in BSP meta data. Today I just find the *.inc file is also need >>> to be appended, so I wonder if there >>> is similar incappend file that can append content to inc file? >>> >>> I meet this requirement when trying to fix bug 896 >>> (http://bugzilla.yoctoproject.org/show_bug.cgi?id=896). To make >>> poky-image-clutter build pass in n450, the clutter.inc need to be >>> appended to change the COMPATIBLE_MACHINE. >> >> Why can't you just put the change in the .bbappend file (since it's >> already recipe/target specific)? >> > > currently there is clutter 1.4 and clutter 1.6 which both use the clutter.inc. and yes, It is also fine to use duplicate bbappend to append clutter 1.4 and clutter 1.6 > respectively. But if clutter.inc can be appended, then it will reduce the duplicate code. Also inc file append has another benefit, when clutter 1.8 is out in the future, the BSP > append code don't need any change. Agreed, but .inc files are not handled the same way as .bb (at all) by the parser code, so I think it would be a pretty significant change to support such. -- ------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------