Re: How to append inc file

[Gary Thomas <gary@mlbassoc.com>]

On 04/02/2011 10:59 AM, Joshua Lock wrote:
> On Sat, 2011-04-02 at 21:36 +0800, Yu Ke wrote:
>> on 2011-4-2 20:57, Gary Thomas wrote:
>>> On 04/02/2011 06:52 AM, Yu Ke wrote:
>>>> Hi,
>>>>
>>>> bbappend file can be used to append content to bb file, and it is very
>>>> useful in BSP meta data. Today I just find the *.inc file is also need
>>>> to be appended, so I wonder if there
>>>> is similar incappend file that can append content to inc file?
>>>>
>>>> I meet this requirement when trying to fix bug 896
>>>> (http://bugzilla.yoctoproject.org/show_bug.cgi?id=896). To make
>>>> poky-image-clutter build pass in n450, the clutter.inc need to be
>>>> appended to change the COMPATIBLE_MACHINE.
>>>
>>> Why can't you just put the change in the .bbappend file (since it's
>>> already recipe/target specific)?
>>>
>>
>> currently there is clutter 1.4 and clutter 1.6 which both use the
>> clutter.inc. and yes, It is also fine to use duplicate bbappend to
>> append clutter 1.4 and clutter 1.6 respectively. But if clutter.inc can
>> be appended, then it will reduce the duplicate code. Also inc file
>> append has another benefit, when clutter 1.8 is out in the future, the
>> BSP append code don't need any change.
>
> IIRC the common way to handle this now is to have shared code across
> versions in clutter.inc then have inc files for the major releases that
> require them (clutter-1.4.inc, clutter-1.6.inc, etc) and then have the
> version inc file include the core inc file.
> The recipes would then include the appropriate inc file for the major
> version (1.6, etc) which they build.

How does that solve the problem that the .inc file needs to have BSP
specific changes (which I find pretty abhorrent BTW)

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------