From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org,
yoshikawa.takuya@oss.ntt.co.jp, gleb@redhat.com
Subject: Re: [RFC PATCH 2/2] KVM: x86 emulator: Cleanup emulate_push() writebacks
Date: Sun, 03 Apr 2011 19:11:11 +0300 [thread overview]
Message-ID: <4D989C1F.6070703@redhat.com> (raw)
In-Reply-To: <20110404010910.c4d417ff.takuya.yoshikawa@gmail.com>
On 04/03/2011 07:09 PM, Takuya Yoshikawa wrote:
> > > IMHO, we are using dst operand for too many things.
> > >
> > > In the case of CMP, I first tried to use src2 to clearly follow the
> > > SDM's "second source operand" terminology. But it seemed not worth
> > > it now.
> > >
> >
> > Ah, CMP is encoded as dst/src, so it's best to just disable writeback
> > there. We could have a bit in the decode tables to auto-disable
> > writeback, but not sure it is worth it.
>
> One more question:
>
> Why some functions in this file are defined using
> "static inline" not just "static" ?
>
> I should keep these "inline" ?
>
Just 'static' is enough, the compiler can usually make the best decision
wrt. inline.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-04-03 16:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 16:32 [PATCH 1/2] KVM: x86 emulator: Disable writeback for CMP emulation Takuya Yoshikawa
2011-03-28 16:34 ` [RFC PATCH 2/2] KVM: x86 emulator: Cleanup emulate_push() writebacks Takuya Yoshikawa
2011-03-30 6:51 ` Takuya Yoshikawa
2011-04-03 14:50 ` Avi Kivity
2011-04-03 15:59 ` Takuya Yoshikawa
2011-04-03 16:04 ` Avi Kivity
2011-04-03 16:09 ` Takuya Yoshikawa
2011-04-03 16:11 ` Avi Kivity [this message]
2011-04-03 14:42 ` [PATCH 1/2] KVM: x86 emulator: Disable writeback for CMP emulation Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D989C1F.6070703@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.