From: John Crispin <blogic@openwrt.org>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Ralph Hempel <ralph.hempel@lantiq.com>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH V5 05/10] MIPS: lantiq: add watchdog support
Date: Mon, 04 Apr 2011 11:24:28 +0200 [thread overview]
Message-ID: <4D998E4C.3060708@openwrt.org> (raw)
In-Reply-To: <20110330093618.GH3974@infomag.iguana.be>
Hi Wim,
some questions inline
>> +ltq_wdt_disable(void)
>> +{
>> +#ifndef CONFIG_WATCHDOG_NOWAYOUT
>> + ltq_wdt_ok_to_close = 0;
>> +#endif
>> + /* write the first password magic */
>> + ltq_w32(LTQ_WDT_PW1, ltq_wdt_membase + LTQ_WDT_CR);
>> + /* write the second password magic with no config
>> + * this turns the watchdog off
>> + */
>> + ltq_w32(LTQ_WDT_PW2, ltq_wdt_membase + LTQ_WDT_CR);
>> +}
>>
> Don't like this ifdef/ifndef stuff. The nowayout things can be done in the /dev/watchdog handling.
>
>
Sorry i am not sure what you mean by "can be done in the /dev/watchdog
handling". could you be so kind and elaborate.
looking at some of the other drivers, there seem to be 2 strategies for
this.
1) using the #ifdef
2) using a module parameter
do you mean the later ?
> Please add the code to make sure that /dev/watchdog can be opened once.
>
>
Do you mean "only" once ?
thanks for the clarification,
John
next prev parent reply other threads:[~2011-04-04 9:23 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 7:27 [PATCH V5 00/10] MIPS: lantiq: add initial support for Lantiq SoCs John Crispin
2011-03-30 7:27 ` [PATCH V5 01/10] " John Crispin
2011-03-31 13:01 ` Ralf Baechle
2011-03-31 13:35 ` John Crispin
2011-03-30 7:27 ` [PATCH V5 02/10] MIPS: lantiq: add SoC specific code for XWAY family John Crispin
2011-03-31 13:01 ` Ralf Baechle
2011-03-30 7:27 ` [PATCH V5 03/10] MIPS: lantiq: add PCI controller support John Crispin
2011-03-31 13:01 ` Ralf Baechle
2011-03-30 7:27 ` [PATCH V5 04/10] MIPS: lantiq: add serial port support John Crispin
2011-03-30 9:33 ` Alan Cox
2011-03-30 7:27 ` [PATCH V5 05/10] MIPS: lantiq: add watchdog support John Crispin
2011-03-30 9:36 ` Wim Van Sebroeck
2011-03-30 9:41 ` John Crispin
2011-04-04 9:24 ` John Crispin [this message]
2011-04-07 14:31 ` Sergei Shtylyov
2011-03-30 7:27 ` [PATCH V5 06/10] MIPS: lantiq: add NOR flash support John Crispin
2011-03-30 7:27 ` John Crispin
2011-04-01 12:43 ` Artem Bityutskiy
2011-04-01 12:43 ` Artem Bityutskiy
2011-04-04 13:36 ` John Crispin
2011-04-04 13:36 ` John Crispin
2011-04-04 14:07 ` Artem Bityutskiy
2011-04-04 14:07 ` Artem Bityutskiy
2011-03-30 7:27 ` [PATCH V5 07/10] MIPS: lantiq: add platform device support John Crispin
2011-03-31 13:01 ` Ralf Baechle
2011-03-30 7:27 ` [PATCH V5 08/10] MIPS: lantiq: add mips_machine support John Crispin
2011-03-31 13:01 ` Ralf Baechle
2011-03-30 7:27 ` [PATCH V5 09/10] MIPS: lantiq: add machtypes for lantiq eval kits John Crispin
2011-03-31 13:02 ` Ralf Baechle
2011-03-30 7:27 ` [PATCH V5 10/10] MIPS: lantiq: add more gpio drivers John Crispin
2011-03-31 13:02 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D998E4C.3060708@openwrt.org \
--to=blogic@openwrt.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=ralph.hempel@lantiq.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.