All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luk Claes <luk-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
To: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: slash appended to filesystem when mtab symlinked to proc
Date: Mon, 04 Apr 2011 16:33:05 +0200	[thread overview]
Message-ID: <4D99D6A1.7080101@debian.org> (raw)

Hi

A Debian user reported a bug that a slash gets appended to the
filesystem when he mounts a share. This only happens when mtab is
symlinked to proc which I can reproduce:

$ grep cifs /etc/fstab
//<host>/<path>	/mnt	cifs	user,user=<username>	0	0

$ mount /mnt

$ grep cifs /etc/mtab
//<host>/<path>/ /mnt cifs
rw,nosuid,nodev,relatime,unc=\\<host>\<path>,username=<username>,uid=1000,forceuid,gid=1000,forcegid,addr=<ip>,file_mode=0755,dir_mode=0755,serverino,rsize=16384,wsize=57344
0 0

$ umount /mnt
umount: /mnt mount disagrees with the fstab

There does not seem to be any other filesystems that append a slash to
the filesystem in proc. Does cifsfs do that intentionally (in which case
the client should cope with it: by means of umount.cifs?) or should it
get fixed in the kernel (maybe the client should still cope with it)?

Can you give me a hand in identifying the code that would need to be
updated to fix this so I can prepare a patch?

Cheers

Luk

             reply	other threads:[~2011-04-04 14:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-04 14:33 Luk Claes [this message]
     [not found] ` <4D99D6A1.7080101-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2011-04-05 15:51   ` slash appended to filesystem when mtab symlinked to proc Jeff Layton
     [not found]     ` <20110405085147.22dc6829-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2011-04-05 22:26       ` [PATCH] mount.cifs: only convert '\' to '/' for dev_name Luk Claes
     [not found]         ` <1302042408-10579-1-git-send-email-luk-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2011-04-05 23:06           ` Jeff Layton
     [not found]             ` <20110405160636.1e956ecf-4QP7MXygkU+dMjc06nkz3ljfA9RmPOcC@public.gmane.org>
2011-04-06  8:46               ` [PATCH] mount.cifs: Use original device string all the way Luk Claes
     [not found]                 ` <1302079615-14411-1-git-send-email-luk-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2011-04-08 18:14                   ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D99D6A1.7080101@debian.org \
    --to=luk-8fiuurrzop0dnm+yrofe0a@public.gmane.org \
    --cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.