From: Patrick McHardy <kaber@trash.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Netfilter Development Mailinglist
<netfilter-devel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Jan Engelhardt <jengelh@medozas.de>
Subject: Re: [PATCH net-next-2.6] netfilter: get rid of atomic ops in fast path
Date: Mon, 04 Apr 2011 17:05:04 +0200 [thread overview]
Message-ID: <4D99DE20.2060404@trash.net> (raw)
In-Reply-To: <1301836523.2837.159.camel@edumazet-laptop>
On 03.04.2011 15:15, Eric Dumazet wrote:
> We currently use a percpu spinlock to 'protect' rule bytes/packets
> counters, after various attempts to use RCU instead.
>
> Lately we added a seqlock so that get_counters() can run without
> blocking BH or 'writers'. But we really only need the seqcount in it.
>
> Spinlock itself is only locked by the current/owner cpu, so we can
> remove it completely.
>
> This cleanups api, using correct 'writer' vs 'reader' semantic.
>
> At replace time, the get_counters() call makes sure all cpus are done
> using the old table.
Applied, thanks Eric.
prev parent reply other threads:[~2011-04-04 15:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 17:07 [PATCH 2/2] netfilter: get rid of atomic ops in fast path Eric Dumazet
2011-03-20 14:41 ` Patrick McHardy
2011-03-20 19:06 ` Eric Dumazet
2011-04-03 13:15 ` [PATCH net-next-2.6] " Eric Dumazet
2011-04-04 15:05 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D99DE20.2060404@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jengelh@medozas.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.