From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44609 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q6mYS-0007Re-R1 for qemu-devel@nongnu.org; Mon, 04 Apr 2011 12:23:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q6mYR-0007RZ-I6 for qemu-devel@nongnu.org; Mon, 04 Apr 2011 12:23:04 -0400 Received: from mail-yw0-f45.google.com ([209.85.213.45]:47075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q6mYR-0007RT-9q for qemu-devel@nongnu.org; Mon, 04 Apr 2011 12:23:03 -0400 Received: by ywl41 with SMTP id 41so2750096ywl.4 for ; Mon, 04 Apr 2011 09:23:02 -0700 (PDT) Message-ID: <4D99F061.1090208@codemonkey.ws> Date: Mon, 04 Apr 2011 11:22:57 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH 00/10] pci: pci_register_bar_simple References: <1301930887-20705-1-git-send-email-avi@redhat.com> <20110404155917.GA13423@redhat.com> In-Reply-To: <20110404155917.GA13423@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Avi Kivity , qemu-devel@nongnu.org On 04/04/2011 10:59 AM, Michael S. Tsirkin wrote: > On Mon, Apr 04, 2011 at 06:27:57PM +0300, Avi Kivity wrote: >> Many PCI BARs that use the memory address space map a single MMIO region into >> the entire BAR range. Introduce an API pci_register_bar_simple() for that use >> case, and convert all users where this can be done trivially. >> >> This will reduce the work required to introduce a PCI memory API; it's also >> a nice code reduction in its own right. > This will save some code, so > Acked-by: Michael S. Tsirkin > > I really hope the rest of devices will follow. How complete is this? From a couple of quick greps, it looks like this covers most everything that it can. Acked-by: Anthony Liguori Regards, Anthony Liguori >> Avi Kivity (10): >> pci: add pci_register_bar_simple() API >> rtl8139: convert to pci_register_bar_simple() >> cirrus-vga: convert to pci_register_bar_simple() >> eepro100: convert to pci_register_bar_simple() >> ich/ahci: convert to pci_register_bar_simple() >> hda-intel: convert to pci_register_bar_simple() >> hda-intel: convert to pci_register_bar_simple() (partial) >> pcnet-pci: convert to pci_register_bar_simple() >> usb-ohci: convert to pci_register_bar_simple() >> wdt_i6300esb: convert to pci_register_bar_simple() >> >> hw/cirrus_vga.c | 13 ++----------- >> hw/eepro100.c | 43 +++++++++++++------------------------------ >> hw/ide/ahci.c | 9 --------- >> hw/ide/ahci.h | 3 --- >> hw/ide/ich.c | 3 +-- >> hw/intel-hda.c | 11 +---------- >> hw/lsi53c895a.c | 12 +----------- >> hw/pci.c | 17 +++++++++++++++++ >> hw/pci.h | 3 +++ >> hw/pcnet-pci.c | 16 +--------------- >> hw/rtl8139.c | 11 +---------- >> hw/usb-ohci.c | 10 +--------- >> hw/wdt_i6300esb.c | 42 +++++++++++++++--------------------------- >> 13 files changed, 56 insertions(+), 137 deletions(-)