From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.multimedia-labs.de ([82.149.226.172]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1Q6oIm-0002FU-9O for openembedded-devel@lists.openembedded.org; Mon, 04 Apr 2011 20:15:00 +0200 Received: from localhost (localhost [127.0.0.1]) by mail.multimedia-labs.de (Postfix) with ESMTP id 79498314FC53 for ; Mon, 4 Apr 2011 20:12:57 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.multimedia-labs.de Received: from mail.multimedia-labs.de ([127.0.0.1]) by localhost (mail.multimedia-labs.de [127.0.0.1]) (amavisd-new, port 10024) with LMTP id GgUZFapvONlR for ; Mon, 4 Apr 2011 20:12:51 +0200 (CEST) Received: from [172.22.22.61] (ip-109-85-231-67.web.vodafone.de [109.85.231.67]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.multimedia-labs.de (Postfix) with ESMTPSA id 816F6314FC51 for ; Mon, 4 Apr 2011 20:12:51 +0200 (CEST) Message-ID: <4D9A0A1D.3020209@opendreambox.org> Date: Mon, 04 Apr 2011 20:12:45 +0200 From: Andreas Oberritter User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Lightning/1.0b2 Thunderbird/3.1.9 MIME-Version: 1.0 To: openembedded-devel@lists.openembedded.org References: <1300981024-9111-2-git-send-email-obi@opendreambox.org> <1300983264-16652-1-git-send-email-obi@opendreambox.org> <4D99C0EA.5070902@opendreambox.org> <4D99E05E.9020100@opendreambox.org> In-Reply-To: Subject: Re: [PATCHv2] kernel/module-base: Append PR to MACHINE_KERNEL_PR X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Apr 2011 18:15:00 -0000 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 04/04/2011 07:54 PM, Koen Kooi wrote: > On 04-04-11 17:14, Andreas Oberritter wrote: >> On 04/04/2011 03:58 PM, Koen Kooi wrote: >>> On 04-04-11 15:00, Andreas Oberritter wrote: >>>> Ping. Any votes for or against this patch with either appended or >>>> prepended PR? >>> >>> I don't like this patch *at all*. Recipes can already do >>> MACHINE_KERNEL_PR_append = "something" if they need to. > >> The use of MACHINE_KERNEL_PR is optional, so it feels really wrong to >> append something to it in a recipe. > >>> Can you should me a specific example on how this would be an improvement? > >> With the version below. a distro can start to use MACHINE_KERNEL_PR any >> time without breaking updates. > >> The vast majority of modules do not use MACHINE_KERNEL_PR > > It seems you don't understand how MACHINE_KERNEL_PR works. The *machine* > sets it. The distro has *no* say in it. Therefore the module recipes > don't need to set it, since it's automatic. That's nitpicking. Let me rephrase: With the previously cited version. a *machine* can start to use MACHINE_KERNEL_PR any time without breaking updates. The vast majority of module recipes do not use MACHINE_KERNEL_PR. That means that they use their own PR instead of appending something to MACHINE_KERNEL_PR, as suggested by you. Setting MACHINE_KERNEL_PR in the machine's configuration disables automatic rebuilds of 91% of module recipes. Regards, Andreas