All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dushyant Bansal <cs5070214@cse.iitd.ac.in>
To: kvm-ppc@vger.kernel.org
Subject: Patching guest kernel code for better performance from HOST
Date: Tue, 05 Apr 2011 08:59:40 +0000	[thread overview]
Message-ID: <4D9AD9E7.20904@cse.iitd.ac.in> (raw)

[-- Attachment #1: Type: text/plain, Size: 2185 bytes --]

Hi all,

     I understand that in order to improve performance by reducing vm 
exits, kvm uses one shared page between kvm and guest. Now, guest tells 
the host to map the magic page to '-4096'.

How does kvm make sure that guest will not use this address ( -4096) for 
other purpose?

Then, guest itself patches its kernel.
I am trying to patch guest from host. So far, I have tried to patch 
MFMSR instruction. Patching is done when kvm tries to emulate MFMSR. 
Mechanism used to generate new instruction is same as used by guest in 
"arch/powerpc/kernel/kvm.c"

--- a/arch/powerpc/kvm/book3s_emulate.c
+++ b/arch/powerpc/kvm/book3s_emulate.c
@@ -88,6 +88,23 @@ int kvmppc_core_emulate_op(struct kvm_run *run, 
struct kvm_vcpu *vcpu,
                 case OP_31_XOP_MFMSR:
                         kvmppc_set_gpr(vcpu, get_rt(inst),
                                        vcpu->arch.shared->msr);
+
+                       pc = kvmppc_get_pc(vcpu);
+
+                       //if pte.may_write==false then, kvmppc_st will 
not work
+                       kvmppc_xlate(vcpu,pc,false, &pte);
+                       pte.may_write=true;
+
+                       //Generate new instruction
+                       addr= (-4096L) + offsetof(struct 
kvm_vcpu_arch_shared, msr);
+                       u32 rt1 = inst & 0x03e00000;
+                       u32 new_inst=0x80000000 | rt1 | ((addr + 4) & 
0x0000fffc);
+
+                       //patch only if magic page is mapped; try 
patching only for 0x7c0000a6 inst
+                       if (vcpu->arch.magic_page_pa==0xfffff000 && 
inst==0x7c0000a6) {
+                                       
kvmppc_st(vcpu,&pc,sizeof(u32),&new_inst,true);
+                                       }
+
                         break;
                 case OP_31_XOP_MTMSRD:
                 {


But, the problem is guest hangs during boot. I have attached the 
screenshot of the guest. I am not able to figure out the problem. Is 
there something wrong with the approach?

I have checked that new_inst generated corresponding to 0x7c0000a6 
instruction matches with the instruction that is generated when guest 
patches itself.


Thanks,
Dushyant

[-- Attachment #2: Screenshot.png --]
[-- Type: image/png, Size: 25341 bytes --]

             reply	other threads:[~2011-04-05  8:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-05  8:59 Dushyant Bansal [this message]
2011-04-05  9:09 ` Patching guest kernel code for better performance from HOST Alexander Graf
2011-04-05 13:42 ` Dushyant Bansal
2011-04-05 13:56 ` Alexander Graf
2011-04-29 22:34 ` Dushyant Bansal
2011-05-07 20:44 ` Dushyant Bansal
2011-05-07 20:52 ` Alexander Graf
2011-05-09 10:38 ` Alexander Graf
2011-05-09 10:46 ` Dushyant Bansal
2011-05-19 11:28 ` Dushyant Bansal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D9AD9E7.20904@cse.iitd.ac.in \
    --to=cs5070214@cse.iitd.ac.in \
    --cc=kvm-ppc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.