[Qemu-devel] Re: [PATCH v3] v9fs_walk: As per 9p2000 RFC, MAXWELEM >= nwnames >= 0.

[Harsh Bora <harsh@linux.vnet.ibm.com>]

On 04/05/2011 02:24 PM, Stefan Hajnoczi wrote:
> On Tue, Apr 5, 2011 at 6:56 AM, Harsh Prateek Bora
> <harsh@linux.vnet.ibm.com>  wrote:
>> The nwnames field in TWALK message is assumed to be>=0 and<= MAXWELEM
>> which is defined as macro P9_MAXWELEM (16) in virtio-9p.h as per 9p2000
>> RFC. Appropriate changes are required in V9fsWalkState and v9fs_walk.
>>
>> v3:
>> - Updated if-else conditions to appropriately handle nwnames = 0.
>>
>> v2:
>> - Added check in v9fs_walk_complete as well.
>>
>> Signed-off-by: Harsh Prateek Bora<harsh@linux.vnet.ibm.com>
>> ---
>>   hw/9pfs/virtio-9p.c |    7 +++++--
>>   hw/9pfs/virtio-9p.h |    2 +-
>>   2 files changed, 6 insertions(+), 3 deletions(-)
>
> hw/virtio-9p.c
>
> I think you've submitted a patch against an internal tree that isn't upstream.

Yes, it is based on a patch yet to be merged in mainline by Aneesh which 
will move 9p files into a separate folder, however, I shall repost an 
updated version of the patch based on current directory structure.

regards,
Harsh
>
> Stefan