From: Jerry Van Baren <gvb.uboot@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/6] Stop passing around bootmem_base value.
Date: Tue, 05 Apr 2011 09:27:51 -0400 [thread overview]
Message-ID: <4D9B18D7.2080608@gmail.com> (raw)
In-Reply-To: <20110328195830.10235.46889.stgit@ponder>
Hi Grant,
On 03/28/2011 03:58 PM, Grant Likely wrote:
> From: Grant Likely<grant.likely@linaro.org>
>
> For the calls to boot_relocate_fdt(), boot_get_cmdline(), and
> boot_get_kbd(), the value of bootmem_base is always obtained by
> calling getenv_bootm_low(). Since the value always comes from the
> same source, the calling signature for those functions can be
> simplified by making them call getenv_bootm_low() directly.
>
> Signed-off-by: Grant Likely<grant.likely@linaro.org>
[snip]
> diff --git a/include/image.h b/include/image.h
> index 005e0d2..aa1d7df 100644
> --- a/include/image.h
> +++ b/include/image.h
[snip]
> @@ -345,11 +344,10 @@ int boot_ramdisk_high (struct lmb *lmb, ulong rd_data, ulong rd_len,
> ulong *initrd_start, ulong *initrd_end);
> #endif /* CONFIG_SYS_BOOT_RAMDISK_HIGH */
> #ifdef CONFIG_SYS_BOOT_GET_CMDLINE
> -int boot_get_cmdline (struct lmb *lmb, ulong *cmd_start, ulong *cmd_end,
> - ulong bootmap_base);
> +int boot_get_cmdline (struct lmb *lmb, ulong *cmd_start, ulong *cmd_end)
___________________________________________________________________________^
D'oh, you lost a semicolon. Compiles for ARM, not so well for PowerPC.
Took me a bit of staring and head scratching to see the missing piece
(the hardest thing to see is the thing that isn't there).
I'm having a problem with patch 2 of 6 as well, getenv_bootm_base() not
found for PowerPC, apparently the code isn't used in ARM.
Thanks,
gvb
next prev parent reply other threads:[~2011-04-05 13:27 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 19:58 [PATCH 0/6] ARM device tree support improvements Grant Likely
2011-03-28 19:58 ` [U-Boot] " Grant Likely
2011-03-28 19:58 ` [PATCH 1/6] Stop passing around bootmem_base value Grant Likely
2011-03-28 19:58 ` [U-Boot] " Grant Likely
2011-04-05 13:27 ` Jerry Van Baren [this message]
2011-03-28 19:58 ` [PATCH 2/6] Default to bootm_size() when CONFIG_SYS_BOOTMAPSZ is not defined Grant Likely
2011-03-28 19:58 ` [U-Boot] " Grant Likely
2011-04-05 13:34 ` Jerry Van Baren
2011-03-28 19:58 ` [PATCH 3/6] Remove device tree booting dependency on CONFIG_SYS_BOOTMAPSZ Grant Likely
2011-03-28 19:58 ` [U-Boot] " Grant Likely
2011-03-28 19:58 ` [PATCH 4/6] Fix off-by-one error in passing initrd end address via device tree Grant Likely
2011-03-28 19:58 ` [U-Boot] " Grant Likely
2011-03-28 19:59 ` [PATCH 5/6] Respect memreserve regions specified in the " Grant Likely
2011-03-28 19:59 ` [U-Boot] " Grant Likely
2011-03-28 19:59 ` [PATCH 6/6] Add CONFIG_OF_LIBFDT to more boards Grant Likely
2011-03-28 19:59 ` [U-Boot] " Grant Likely
2011-04-27 22:44 ` Wolfgang Denk
2011-04-27 22:44 ` [U-Boot] " Wolfgang Denk
2011-04-28 9:22 ` Albert ARIBAUD
2011-04-28 9:22 ` [U-Boot] " Albert ARIBAUD
2011-04-28 12:51 ` Albert ARIBAUD
2011-04-28 12:51 ` [U-Boot] " Albert ARIBAUD
2011-03-29 6:46 ` [PATCH 0/6] ARM device tree support improvements Shawn Guo
2011-03-29 6:46 ` [U-Boot] " Shawn Guo
2011-04-28 0:48 ` [U-Boot] [PATCH 1/2] Remove unnecessary CONFIG_SYS_BOOTMAPSZ definition Shawn Guo
2011-04-28 0:48 ` [U-Boot] [PATCH 2/2] Fix CONFIG_OF_LIBFDT redefined warning Shawn Guo
2011-05-04 6:13 ` [U-Boot] [PATCH RESEND 1/2] mx5: Remove unnecessary CONFIG_SYS_BOOTMAPSZ definition Shawn Guo
2011-05-04 6:13 ` [U-Boot] [PATCH RESEND 2/2] mx5: Fix CONFIG_OF_LIBFDT redefined warning Shawn Guo
2011-05-04 8:04 ` Stefano Babic
2011-05-04 8:44 ` Shawn Guo
2011-05-04 8:50 ` Stefano Babic
2011-05-15 14:30 ` Stefano Babic
2011-05-15 14:31 ` [U-Boot] [PATCH RESEND 1/2] mx5: Remove unnecessary CONFIG_SYS_BOOTMAPSZ definition Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9B18D7.2080608@gmail.com \
--to=gvb.uboot@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.