From: Nick Thompson <nick.thompson@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] CONFIG_SILENT_CONSOLE not working with NAND env
Date: Tue, 05 Apr 2011 15:07:47 +0100 [thread overview]
Message-ID: <4D9B2233.5060506@ge.com> (raw)
common/console.c has this function:
/* Called before relocation - use serial functions */
int console_init_f(void)
{
gd->have_console = 1;
#ifdef CONFIG_SILENT_CONSOLE
if (getenv("silent") != NULL)
gd->flags |= GD_FLG_SILENT;
#endif
return 0;
}
I have defined CONFIG_SILENT_CONSOLE and set "silent" in my NAND env,
but the SILENT flag doesn't get set.
I suspect this function is called way too early for NAND env to be available.
I can set the flag unconditionally and that works fine, but I don't think that
that will make a patch worthy of submission...?
Any thoughts?
Thanks,
Nick.
next reply other threads:[~2011-04-05 14:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 14:07 Nick Thompson [this message]
2011-04-05 15:52 ` [U-Boot] CONFIG_SILENT_CONSOLE not working with NAND env Mike Frysinger
2011-04-05 16:07 ` Nick Thompson
2011-04-05 17:46 ` Scott Wood
2011-04-06 8:21 ` Nick Thompson
2011-04-06 9:22 ` Wolfgang Denk
2011-04-06 10:06 ` Nick Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9B2233.5060506@ge.com \
--to=nick.thompson@ge.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.