All of lore.kernel.org
 help / color / mirror / Atom feed
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: BUG() dies silently
Date: Tue, 05 Apr 2011 10:36:39 -0700	[thread overview]
Message-ID: <4D9B5327.1070709@codeaurora.org> (raw)
In-Reply-To: <BANLkTimJkQ9afnO=6gKiBqWUo+Uv=hWx2Q@mail.gmail.com>

On 4/4/2011 6:55 PM, Simon Glass wrote:
> On Sun, Apr 3, 2011 at 12:15 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>> Yes I've seen your patch (and even posted comments on it which have not
>> been responded to).
> Hi Stephen,
>
> Not yet! Don't worry I will get to it. I like the suggestion and am
> pleased that you pointed me to it, thank you.
>

Great!

>> Correct me if I'm wrong, but that patch with CONFIG_BUG=n would lead to
>> the same error that Omar is seeing because the code only modifies the
>> bug infrastructure when CONFIG_BUG=y.
> Well if CONFIG_BUG=n then there is no bug infrastructure, The whole
> file is skipped and it falls back to the asm-generic/bug.h which has
> even more #ifdefs in it. But I think we end up here:
>
> #define BUG() do {} while(0)
>
> After all the patch removes the *(int*)0 = 0 code by virtue of
> CONFIG_GENERIC_BUG=y, right? If I have this wrong then I will have to
> break out the C preprocessor...
>

Ah you're right. Too many ifdefs going on there.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Simon Glass <sjg@chromium.org>
Cc: Omar Ramirez Luna <omar.ramirez@ti.com>,
	Russell King <linux@arm.linux.org.uk>,
	lk <linux-kernel@vger.kernel.org>,
	lak <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: BUG() dies silently
Date: Tue, 05 Apr 2011 10:36:39 -0700	[thread overview]
Message-ID: <4D9B5327.1070709@codeaurora.org> (raw)
In-Reply-To: <BANLkTimJkQ9afnO=6gKiBqWUo+Uv=hWx2Q@mail.gmail.com>

On 4/4/2011 6:55 PM, Simon Glass wrote:
> On Sun, Apr 3, 2011 at 12:15 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
>> Yes I've seen your patch (and even posted comments on it which have not
>> been responded to).
> Hi Stephen,
>
> Not yet! Don't worry I will get to it. I like the suggestion and am
> pleased that you pointed me to it, thank you.
>

Great!

>> Correct me if I'm wrong, but that patch with CONFIG_BUG=n would lead to
>> the same error that Omar is seeing because the code only modifies the
>> bug infrastructure when CONFIG_BUG=y.
> Well if CONFIG_BUG=n then there is no bug infrastructure, The whole
> file is skipped and it falls back to the asm-generic/bug.h which has
> even more #ifdefs in it. But I think we end up here:
>
> #define BUG() do {} while(0)
>
> After all the patch removes the *(int*)0 = 0 code by virtue of
> CONFIG_GENERIC_BUG=y, right? If I have this wrong then I will have to
> break out the C preprocessor...
>

Ah you're right. Too many ifdefs going on there.

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.


  reply	other threads:[~2011-04-05 17:36 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-31 20:15 [PATCH] ARM: BUG() dies silently Omar Ramirez Luna
2011-03-31 20:15 ` Omar Ramirez Luna
2011-04-01  1:47 ` Simon Glass
2011-04-01  1:47   ` Simon Glass
2011-04-01  8:44   ` Stephen Boyd
2011-04-01  8:44     ` Stephen Boyd
2011-04-01 22:29     ` Simon Glass
2011-04-01 22:29       ` Simon Glass
2011-04-03  7:15       ` Stephen Boyd
2011-04-03  7:15         ` Stephen Boyd
2011-04-05  1:55         ` Simon Glass
2011-04-05  1:55           ` Simon Glass
2011-04-05 17:36           ` Stephen Boyd [this message]
2011-04-05 17:36             ` Stephen Boyd
2011-04-05  2:29         ` Ramirez Luna, Omar
2011-04-05  2:29           ` Ramirez Luna, Omar
2011-04-05  5:46           ` Simon Glass
2011-04-05  5:46             ` Simon Glass
2011-04-05 16:02             ` Ramirez Luna, Omar
2011-04-05 16:02               ` Ramirez Luna, Omar
2011-04-05 16:43               ` Simon Glass
2011-04-05 16:43                 ` Simon Glass
2011-09-17  6:07 ` Rabin Vincent
2011-09-17  6:07   ` Rabin Vincent
2011-09-19 14:26   ` Ramirez Luna, Omar
2011-09-19 14:26     ` Ramirez Luna, Omar
2011-09-19 14:43     ` Russell King - ARM Linux
2011-09-19 14:43       ` Russell King - ARM Linux
2011-09-19 16:59       ` Russell King - ARM Linux
2011-09-19 16:59         ` Russell King - ARM Linux
2011-09-19 18:02         ` Simon Glass
2011-09-19 18:02           ` Simon Glass
2011-09-19 18:25           ` Russell King - ARM Linux
2011-09-19 18:25             ` Russell King - ARM Linux
2011-09-19 18:32             ` Ramirez Luna, Omar
2011-09-19 18:32               ` Ramirez Luna, Omar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D9B5327.1070709@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.