All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Henry Ptasinski" <henryp@broadcom.com>
To: "Larry Finger" <Larry.Finger@lwfinger.net>
Cc: "dwmw2@infradead.org" <dwmw2@infradead.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
	"Brett Rudley" <brudley@broadcom.com>,
	"Arend Van Spriel" <arend@broadcom.com>,
	"Roland Vossen" <rvossen@broadcom.com>,
	"Henry Ptasinski" <henryp@broadcom.com>
Subject: Re: [PATCH 2/3] linux-firmware: Removed codeversion from brcm firmware filenames.
Date: Tue, 5 Apr 2011 10:51:00 -0700	[thread overview]
Message-ID: <4D9B5684.6020304@broadcom.com> (raw)
In-Reply-To: <4D9B3679.10509@lwfinger.net>

On 04/05/2011 08:34 AM, Larry Finger wrote:
> I also endorse removing the version number from the firmware name; however, I
> see a fundamental flaw in the present submission. Both brcmsmac and its
> predecessor brcm80211 have been included in mainline and compat-wireless, have
> been widely distributed, and have a number of users. This change will break the
> system of every one of them - including mine.

Hmm.  Sounds like you've got the firmware installed with it's original 
name, and are using symlinks.  Is that correct?  A lot of installations 
(including at least one major distro) rename the files, and skip the 
whole symlink approach.

That's we decided to dump the version number appendage.  However, if 
there are a mix of installation approaches, we should take a somewhat 
different approach on the fix.

 > My proposed solution is to do the
> rename as done in this patch, but also include links to the new name from every
> name used in any distributed version.

The brcm80211/brcmsmac driver has always looked for "brcm/bcm43xx-0.fw". 
  It never looked for the version info on the filename.  So I don't 
quite understand what you mean by "from every name used in any 
distributed version", as the only name used in all distributed versions 
of the driver is exactly the name we're trying to give to the firmware 
file.  Could you clarify?

Thanks,
- Henry


  reply	other threads:[~2011-04-05 17:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-05 14:58 [PATCH 0/3] linux-firmware: Updated firmware and new license for brcm firmware Henry Ptasinski
2011-04-05 14:58 ` [PATCH 2/3] linux-firmware: Removed codeversion from brcm firmware filenames Henry Ptasinski
2011-04-05 15:34   ` Larry Finger
2011-04-05 17:51     ` Henry Ptasinski [this message]
2011-04-05 19:00       ` Larry Finger
2011-04-05 19:29         ` Greg KH
2011-04-05 20:33           ` Larry Finger
2011-04-05 20:42             ` Greg KH
2011-04-05 14:58 ` [PATCH 3/3] linux-firmware: updated firmware for BCM4313, BCM43224, and BCM43225 chips Henry Ptasinski
2011-04-21 18:30   ` [PATCH 0/3] linux-firmware: brcm firmware fixes Henry Ptasinski
2011-04-21 18:30     ` [PATCH 1/3] linux-firmware: Simplified license file for brcm firmware Henry Ptasinski
2011-04-21 18:30     ` [PATCH 2/3] linux-firmware: Removed codeversion from brcm firmware filenames Henry Ptasinski
2011-04-21 18:30     ` [PATCH 3/3] linux-firmware: updated firmware for BCM4313, BCM43224, and BCM43225 chips Henry Ptasinski
2011-04-07 21:15 ` [PATCH 0/3] linux-firmware: Updated firmware and new license for brcm firmware Henry Ptasinski
2011-04-08  6:41   ` Johannes Berg
2011-04-08 14:49     ` Henry Ptasinski
2011-04-08 14:51   ` [PATCH 1/3] linux-firmware: Simplified license file " Henry Ptasinski
2011-04-08 14:51   ` [PATCH 2/3] linux-firmware: Removed codeversion from brcm firmware filenames Henry Ptasinski
2011-04-08 14:51   ` [PATCH 3/3] linux-firmware: updated firmware for BCM4313, BCM43224, and BCM43225 chips Henry Ptasinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D9B5684.6020304@broadcom.com \
    --to=henryp@broadcom.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=arend@broadcom.com \
    --cc=brudley@broadcom.com \
    --cc=devel@linuxdriverproject.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rvossen@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.