From: Oliver Hartkopp <socketcan@hartkopp.net>
To: David Miller <davem@davemloft.net>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
Kurt Van Dijck <kurt.van.dijck@eia.be>,
Eric Dumazet <eric.dumazet@gmail.com>,
Urs Thuermann <urs@isnogud.escape.de>
Subject: Re: [PATCH net-next-2.6] can: convert protocol handling to RCU
Date: Tue, 05 Apr 2011 19:52:35 +0200 [thread overview]
Message-ID: <4D9B56E3.9080207@hartkopp.net> (raw)
In-Reply-To: <4D9A2844.2080304@hartkopp.net>
On 04.04.2011 22:21, Oliver Hartkopp wrote:
> This patch removes spin_locks at CAN socket creation time by using RCU.
>
> @@ -143,22 +159,18 @@ static int can_create(struct net *net, struct socket *sock, int protocol,
> if (err && printk_ratelimit())
> printk(KERN_ERR "can: request_module "
> "(can-proto-%d) failed.\n", protocol);
> + else
> + cp = can_try_module_get(protocol);
> }
Hm, i just discovered a tiny issue here as putting can_try_module_get() into
the 'else' path is not needed.
Will send a V2 in a few minutes.
Regards,
Oliver
prev parent reply other threads:[~2011-04-05 17:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 20:21 [PATCH net-next-2.6] can: convert protocol handling to RCU Oliver Hartkopp
2011-04-04 20:26 ` Eric Dumazet
2011-04-05 17:52 ` Oliver Hartkopp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9B56E3.9080207@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=kurt.van.dijck@eia.be \
--cc=netdev@vger.kernel.org \
--cc=urs@isnogud.escape.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.