From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Q7Bji-0004en-Tk for mharc-grub-devel@gnu.org; Tue, 05 Apr 2011 15:16:22 -0400 Received: from [140.186.70.92] (port=34996 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q7Bjf-0004eL-VU for grub-devel@gnu.org; Tue, 05 Apr 2011 15:16:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q7Bje-0000x0-Md for grub-devel@gnu.org; Tue, 05 Apr 2011 15:16:19 -0400 Received: from mail-ww0-f49.google.com ([74.125.82.49]:35839) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q7Bje-0000wW-IA for grub-devel@gnu.org; Tue, 05 Apr 2011 15:16:18 -0400 Received: by wwb39 with SMTP id 39so734976wwb.30 for ; Tue, 05 Apr 2011 12:16:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=MHXYeOcmuOhezxEBE0K9X61Fc6VPAvTsFq8YcRWQGlI=; b=iUbP3ifII8uVnN2I5zTyoU5xE4q/CIYQDC9rOVyi9Yxzq3N1ikVATIf+ThOV4rHf4G TBQdw0KEyKp5ybkTn6//hrkG/V4yBYvuZVuX+gHIbt1jNr7+lVTnPzcHtD3S3t77SQqH vb4nmVckh1pfWOKKghWBrCxj3ERcNPQtoOEvg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=Q39mmPoNL9ihkNS2jwoTsUzEvXGIU/Xnp1eSJ/R496zxkd8MH/qVq7c0VXoAk6eQfD nhZbXc3F8ueMUbo7MbD/TLcHKs83xkShyfsRExTuuMVJQJ3IntHHp287UzLja5qLM/Tf FyyuMmjYUb1WtlzMtYiqB6mUiDkC4dAuWxtQw= Received: by 10.227.55.4 with SMTP id s4mr11564wbg.228.1302030977048; Tue, 05 Apr 2011 12:16:17 -0700 (PDT) Received: from [192.168.0.101] (eab95-4-88-175-177-37.fbx.proxad.net [88.175.177.37]) by mx.google.com with ESMTPS id z13sm3759094wbd.29.2011.04.05.12.16.15 (version=SSLv3 cipher=OTHER); Tue, 05 Apr 2011 12:16:16 -0700 (PDT) Message-ID: <4D9B6A7D.4090306@gmail.com> Date: Tue, 05 Apr 2011 21:16:13 +0200 From: =?UTF-8?B?Tmljb2xhcyBkZSBQZXNsb8O8YW4=?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20110303 Icedove/3.0.11 MIME-Version: 1.0 To: Alexander Kurtz References: <1302008107.14852.20.camel@alexander> In-Reply-To: <1302008107.14852.20.camel@alexander> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 74.125.82.49 Cc: The development of GNU GRUB Subject: Re: [PATCH] add proper variable quoting to grub-mkconfig_lib (Debian bug #612417) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2011 19:16:21 -0000 Le 05/04/2011 14:55, Alexander Kurtz a écrit : > Hi, > > currently you can't use an image which has whitespace in its filename as > GRUB background image because grub-mkconfig_lib lacks proper variable > quoting (see [1] for more information). I've attached three patches > which should fix this problem: > > quote-big.patch: > This patch fixes the problem with the minimal set of changes. > > quote-medium.patch: > This patch adds proper quoting wherever it is safe to do so. > > quote-small.patch > This patch additionally adds quoting in cases like this: > ${grub-probe} --foo --bar => "${grub-probe}" --foo --bar > This breaks things if ${grub-probe} contains additional parameters. > > Please note that I already submitted similar patches a while ago[2], but > these are a little outdated now. The attached patches have been > refreshed and should apply cleanly to the current trunk. > > What do you think? Why do you use construct like "${x}" instead of "$x"? ${x} is useless, unless the character that follow $x might be part of the variable name: "${x}y" is obviously different from "$xy", but "${x}" is identical to "$x". Nicolas. > > Best regards > > Alexander Kurtz > > [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=612417#5 > [2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=612417#10 > > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel