From: "H. Peter Anvin" <hpa@zytor.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Ingo Molnar <mingo@elte.hu>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
"x86@kernel.org" <x86@kernel.org>,
"yinghai@kernel.org" <yinghai@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@suse.de>,
"lkml20101129@newton.leun.net" <lkml20101129@newton.leun.net>,
stable kernel team <stable@kernel.org>,
Jeremy Fitzhardinge <Jeremy.Fitzhardinge@citrix.com>
Subject: Re: [PATCH urgent] x86: Save cr4 to mmu_cr4_features at boot time
Date: Tue, 05 Apr 2011 21:45:42 -0700 [thread overview]
Message-ID: <4D9BEFF6.1030907@zytor.com> (raw)
In-Reply-To: <201104060634.12555.rjw@sisk.pl>
On 04/05/2011 09:34 PM, Rafael J. Wysocki wrote:
>
> Do you mean during resume?
>
> I think we can try to make the ordering more appropriate, but I'm not really
> sure it would be a good idea to do that in the same patch. Probably not.
>
> Also, our current ordering has never been reported to cause problems to anyone.
>
Yes, I mean on resume.
I'm not sure if we'd know since it would manifest as a very early failure.
Anyway, agreed it's not the same patch.
Two things:
1. Do you agree that this is the right place to put this? There seems
to be some other things in __save_processor_state() which puts things in
places outside struct saved_context, but I would like your opinion.
2. While we're at it, why is mtrr_save_fixed_ranges() only called on x86-32?
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2011-04-06 4:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 16:38 [PATCH urgent] x86: Save cr4 to mmu_cr4_features at boot time Stefano Stabellini
2011-04-01 6:23 ` Ingo Molnar
2011-04-01 11:30 ` Stefano Stabellini
2011-04-01 18:51 ` H. Peter Anvin
2011-04-01 19:08 ` Ingo Molnar
2011-04-01 20:59 ` [stable] " Greg KH
2011-04-01 22:57 ` Stefano Stabellini
2011-04-04 15:11 ` Ingo Molnar
2011-04-04 15:47 ` Stefano Stabellini
2011-04-04 16:25 ` Ingo Molnar
2011-04-05 6:29 ` Rafael J. Wysocki
2011-04-05 6:37 ` H. Peter Anvin
2011-04-05 6:43 ` Rafael J. Wysocki
2011-04-05 6:55 ` H. Peter Anvin
2011-04-05 23:47 ` H. Peter Anvin
2011-04-06 4:34 ` Rafael J. Wysocki
2011-04-06 4:45 ` H. Peter Anvin [this message]
2011-04-11 23:04 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9BEFF6.1030907@zytor.com \
--to=hpa@zytor.com \
--cc=Jeremy.Fitzhardinge@citrix.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml20101129@newton.leun.net \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=stable@kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.