From: Michael Tokarev <mjt@tls.msk.ru>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] trivial: fix comment around qdev_init_nofail()
Date: Wed, 06 Apr 2011 17:51:59 +0400 [thread overview]
Message-ID: <4D9C6FFF.2060807@msgid.tls.msk.ru> (raw)
Resending (previous attempt was at Wed, 30 Mar 2011).
In previous life qdev_init_nofail() used to call hw_error() which
did register dump and other scary things. Now it calls
error_report() and does a regular exit(1). Fix the comment
to match reality.
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
hw/qdev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index 1aa1ea0..2f4846e 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -358,7 +358,7 @@ int qdev_simple_unplug_cb(DeviceState *dev)
return 0;
}
-/* Like qdev_init(), but terminate program via hw_error() instead of
+/* Like qdev_init(), but terminate program via error_report() instead of
returning an error value. This is okay during machine creation.
Don't use for hotplug, because there callers need to recover from
failure. Exception: if you know the device's init() callback can't
--
1.7.2.5
next reply other threads:[~2011-04-06 13:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 13:51 Michael Tokarev [this message]
2011-04-06 20:42 ` [Qemu-devel] [PATCH] trivial: fix comment around qdev_init_nofail() Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2011-03-30 12:16 Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9C6FFF.2060807@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.