From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH 1/5] ppce500_mpc8544ds: Fix compile with --enable-debug and --disable-kvm
Date: Thu, 07 Apr 2011 18:52:09 +1000 [thread overview]
Message-ID: <4D9D7B39.7030003@ozlabs.ru> (raw)
In-Reply-To: <A1FEFFEF-0073-4842-941A-2FC13CD83C2C@suse.de>
On 07.04.2011 18:42, Alexander Graf wrote:
> On 07.04.2011, at 05:02, David Gibson wrote:
>
>> From: Alexey Kardashevskiy<aik@ozlabs.ru>
>>
>> When configured with --enable-debug, the makefile does not use any
>> optimization and compilation of hw/ppce500_mpc8544ds.c fails because gcc
>> does not remove the never called without kvm function
>> mpc8544_copy_soc_cell(), which will fail to link without the kvm code.
> I'm not sure I can follow. So the problem is that we call kvmppc_read_host_property and don't provide a stub wrapper for it? Let's provide a wrapper then instead of crippling the target code :)
The problems exists only with --disable-kvm and --enable-debug. Without
--enable-debug, qemu is compiled with -O2, gcc detects that
kvm_enabled() always returns false and optimizes out
mpc8544_copy_soc_cell calls which will not be called anyway. With
--enable-debug, the linker cannot find symbols which it won't call anyway.
alexey.
next prev parent reply other threads:[~2011-04-07 8:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 3:02 [Qemu-devel] Assorted trivial bugfixes David Gibson
2011-04-07 3:02 ` [Qemu-devel] [PATCH 1/5] ppce500_mpc8544ds: Fix compile with --enable-debug and --disable-kvm David Gibson
2011-04-07 8:42 ` Alexander Graf
2011-04-07 8:52 ` Alexey Kardashevskiy [this message]
2011-04-07 9:06 ` Alexander Graf
2011-04-07 3:02 ` [Qemu-devel] [PATCH 2/5] spapr_llan: Fix warning when compiled with -dDEBUG David Gibson
2011-04-07 3:02 ` [Qemu-devel] [PATCH 3/5] virtio-9p: fixed LE-to-host conversion bug when QEMU is called from guest David Gibson
2011-04-07 3:02 ` [Qemu-devel] [PATCH 4/5] virtio-balloon: fixed endianness bug in the config space David Gibson
2011-04-07 3:02 ` [Qemu-devel] [PATCH 5/5] virtio-serial: Fix " David Gibson
2011-04-07 8:57 ` [Qemu-devel] Assorted trivial bugfixes Stefan Hajnoczi
2011-04-08 3:46 ` David Gibson
2011-04-08 9:29 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9D7B39.7030003@ozlabs.ru \
--to=aik@ozlabs.ru \
--cc=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.