[Qemu-devel] Re: [PATCH v3 0/2] Correct transitions for cd change state

[Paolo Bonzini <pbonzini@redhat.com>]

On 04/07/2011 10:46 AM, Amit Shah wrote:
> Hello,
>
> These two patches fix the cd media size change bugs.
>
> The test scenario is:
>
> 1. create an iso image from a file
> 2. create a second iso image from a bigger file
> 3. mount 1st cd in guest
> 4. unmount it
> 5. change cd via qemu monitor
> 6. mount 2nd cd
> 7. copy file on cd to local disk -- shows errors.
>
> v2: Set media_change_notified to 1 if SENSE_UNIT_ATTENTION is not set
> after migration.  This is the only thing needed for migration compat.
>
> v3:
>   - Use cdrom_changed to hold all state changes instead of introducing
>     a new variable. (Paolo Bonzini)
>   - Slightly better comment and commit messages
>
> Please apply.
>
> Amit Shah (2):
>    cdrom: Allow the TEST_UNIT_READY command after a cdrom change
>    cdrom: Make disc change event visible to guests
>
>   hw/ide/core.c |   56 +++++++++++++++++++++++++++++++++++++++++++++++---------
>   1 files changed, 47 insertions(+), 9 deletions(-)
>

Thanks!

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo