Re: [PATCH] USB: Fix trout build failure with ci13xxx_msm gadget

[Pavan Kondeti <pkondeti@codeaurora.org>]

On 4/5/2011 6:25 PM, Felipe Balbi wrote:
> On Fri, Feb 04, 2011 at 10:08:18AM +0530, Pavankumar Kondeti wrote:
>> This patch fixes the below compilation errors.
>>
>>   CC      drivers/usb/gadget/ci13xxx_msm.o
>>   CC      net/mac80211/led.o
>>   drivers/usb/gadget/ci13xxx_msm.c: In function 'ci13xxx_msm_notify_event':
>>   drivers/usb/gadget/ci13xxx_msm.c:42: error: 'USB_AHBBURST' undeclared (first use in this function)
>>   drivers/usb/gadget/ci13xxx_msm.c:42: error: (Each undeclared identifier is reported only once
>>   drivers/usb/gadget/ci13xxx_msm.c:42: error: for each function it appears in.)
>>   drivers/usb/gadget/ci13xxx_msm.c:43: error: 'USB_AHBMODE' undeclared (first use in this function)
>> make[4]: *** [drivers/usb/gadget/ci13xxx_msm.o] Error 1
>> make[3]: *** [drivers/usb/gadget] Error 2
>>
>> MSM USB driver is not supported on boards like trout (MSM7201) which
>> has an external PHY.
>>
>> Signed-off-by: Pavankumar Kondeti <pkondeti@codeaurora.org>
> 
> the real fix, though, would be to phase out the PHY to
> drivers/usb/otg/blablabla.c. ci13xxx_msm.c shouldn't assume the PHY it's
> using. That's wrong.
> 
Agreed. Thanks for pointing this out.

I think OTG driver should bail out if the PHY (or SoC) is not supported;
which means otg_get_transceiver() returns NULL and gadget/host driver's
probe also will fail.

-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.