From: Christoph Egger <Christoph.Egger@amd.com>
To: xen-devel@lists.xensource.com
Subject: Re: [PATCH 0 of 7] libxl: refactor tap disk handling
Date: Thu, 7 Apr 2011 14:31:45 +0200 [thread overview]
Message-ID: <4D9DAEB1.2070407@amd.com> (raw)
In-Reply-To: <patchbomb.1302169946@localhost.localdomain>
On 04/07/11 11:52, Ian Campbell wrote:
> I'm not personally convinced that support for blktap2 devices should
> be conflated in libxl with the PV block backend support but given it's
> there lets at least correct it.
>
> In a blktap2 system there is no "tap" PV backend type. blktap2 exposes
> a standard block device and this is passed to a guest using the
> standard blkback "vbd" (sometimes called "phy") backend. Drop the
> "tap" backend type and associated (libxl internal ) DEVICE_TAP
> enumeration value.
What happens on a no-blktap2 system?
>
> Also try and clarify the paths which fallback from blktap2 to qdisk
> when the former is not present. Falling through a switch statement is
> a neat way of doing this in some cases, but I don't think this is one
> of them.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2011-04-07 12:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 9:52 [PATCH 0 of 7] libxl: refactor tap disk handling Ian Campbell
2011-04-07 9:52 ` [PATCH 1 of 7] libxl: remove impossible check for backend != DISK_BACKEND_QDISK Ian Campbell
2011-04-07 9:52 ` [PATCH 2 of 7] libxl: make fallback from blktap2 to qdisk more explicit Ian Campbell
2011-04-07 9:52 ` [PATCH 3 of 7] libxl: convert an empty tap disk into a qdisk Ian Campbell
2011-04-07 9:52 ` [PATCH 4 of 7] libxl: only a CDROM type disk can be empty Ian Campbell
2011-04-07 9:52 ` [PATCH 5 of 7] libxl: refactor DISK_BACKEND_PHY handling in libxl_device_disk_add Ian Campbell
2011-04-07 9:52 ` [PATCH 6 of 7] libxl: handle the tail end of a tap device using the phy backend handling code Ian Campbell
2011-04-07 9:52 ` [PATCH 7 of 7] libxl: Drop internal DEVICE_TAP backend type Ian Campbell
2011-04-08 15:46 ` Ian Jackson
2011-04-07 12:31 ` Christoph Egger [this message]
2011-04-07 14:12 ` [PATCH 0 of 7] libxl: refactor tap disk handling Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9DAEB1.2070407@amd.com \
--to=christoph.egger@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.