All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael J Gruber <git@drmicha.warpmail.net>
To: Git Mailing List <git@vger.kernel.org>
Subject: t3306 failure with v1.7.5-rc1
Date: Fri, 08 Apr 2011 11:03:56 +0200	[thread overview]
Message-ID: <4D9ECF7C.6010709@drmicha.warpmail.net> (raw)

Heya,

I get this stupid test failure in test 3 of t3306. The problem is that a
dangling commit does not get pruned away when it should:

3rd
test_must_fail: command succeeded: git cat-file -p
5ee1c35e83ea47cd3cc4f8cbee0568915fbbbd29
not ok - 4 verify that commits are gone

It's a system where make complains about funny clock (I dunno why) but
can we make this more robust? The following helps with "sleep 5" but not
with "sleep 4". test_tick does not help. What's going on?

---

diff --git i/t/t3306-notes-prune.sh w/t/t3306-notes-prune.sh
index c428217..da76463 100755
--- i/t/t3306-notes-prune.sh
+++ w/t/t3306-notes-prune.sh
@@ -62,7 +62,9 @@ test_expect_success 'remove some commits' '

 	git reset --hard HEAD~1 &&
 	git reflog expire --expire=now HEAD &&
+	sleep 5 &&
 	git gc --prune=now
 '

 test_expect_success 'verify that commits are gone' '

             reply	other threads:[~2011-04-08  7:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-08  9:03 Michael J Gruber [this message]
2011-04-08  7:06 ` t3306 failure with v1.7.5-rc1 Johannes Sixt
2011-04-08  7:13   ` Michael J Gruber
2011-04-08  7:41     ` "prune" prone to clock skew (Re: t3306 failure with v1.7.5-rc1) Michael J Gruber
2011-04-08 16:30       ` Jeff King
2011-04-08 18:51         ` Junio C Hamano
2011-04-08 18:53           ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D9ECF7C.6010709@drmicha.warpmail.net \
    --to=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.