From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v2 1/5] hpet 'driftfix': add hooks required to detect coalesced interrupts (x86 apic only) Date: Fri, 08 Apr 2011 17:51:51 +0200 Message-ID: <4D9F2F17.7080506@siemens.com> References: <1302276042-3497-1-git-send-email-uobergfe@redhat.com> <1302276042-3497-2-git-send-email-uobergfe@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , "gcosta@redhat.com" , "avi@redhat.com" , "aliguori@us.ibm.com" To: Ulrich Obergfell Return-path: Received: from david.siemens.de ([192.35.17.14]:30635 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757203Ab1DHPwD (ORCPT ); Fri, 8 Apr 2011 11:52:03 -0400 In-Reply-To: <1302276042-3497-2-git-send-email-uobergfe@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 2011-04-08 17:20, Ulrich Obergfell wrote: > 'target_get_irq_delivered' and 'target_reset_irq_delivered' contain > entry addresses of functions that are utilized by update_irq() to > detect coalesced interrupts. apic code loads these pointers during > initialization. This interface is intended as a temporary helper to allow establishing the driftfix infrastructure, right? Then please leave proper comments behind that it will die once we have a real feedback path for IRQ delivery (that also takes routing into account). Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=53868 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q8DyY-0002Rb-Rr for qemu-devel@nongnu.org; Fri, 08 Apr 2011 11:51:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q8DyU-0006ED-Pd for qemu-devel@nongnu.org; Fri, 08 Apr 2011 11:51:58 -0400 Received: from david.siemens.de ([192.35.17.14]:29000) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q8DyU-0006D7-H0 for qemu-devel@nongnu.org; Fri, 08 Apr 2011 11:51:54 -0400 Message-ID: <4D9F2F17.7080506@siemens.com> Date: Fri, 08 Apr 2011 17:51:51 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1302276042-3497-1-git-send-email-uobergfe@redhat.com> <1302276042-3497-2-git-send-email-uobergfe@redhat.com> In-Reply-To: <1302276042-3497-2-git-send-email-uobergfe@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2 1/5] hpet 'driftfix': add hooks required to detect coalesced interrupts (x86 apic only) List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ulrich Obergfell Cc: "avi@redhat.com" , "aliguori@us.ibm.com" , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" , "gcosta@redhat.com" On 2011-04-08 17:20, Ulrich Obergfell wrote: > 'target_get_irq_delivered' and 'target_reset_irq_delivered' contain > entry addresses of functions that are utilized by update_irq() to > detect coalesced interrupts. apic code loads these pointers during > initialization. This interface is intended as a temporary helper to allow establishing the driftfix infrastructure, right? Then please leave proper comments behind that it will die once we have a real feedback path for IRQ delivery (that also takes routing into account). Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux