All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Scott Wood <scottwood@freescale.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] configure: avoid basename usage message
Date: Fri, 08 Apr 2011 15:06:57 -0500	[thread overview]
Message-ID: <4D9F6AE1.1030808@codemonkey.ws> (raw)
In-Reply-To: <20110408185602.GA15734@stefanha-thinkpad.localdomain>

On 04/08/2011 01:56 PM, Stefan Hajnoczi wrote:
> On Fri, Apr 08, 2011 at 11:33:49AM -0500, Scott Wood wrote:
>> diff --git a/configure b/configure
>> index ae97e11..c5b85fe 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1233,7 +1233,8 @@ else
>>     fi
>>     sdl=no
>>   fi
>> -if test -n "$cross_prefix"&&  test "`basename $sdlconfig`" = sdl-config; then
>> +if test -n "$cross_prefix" -a -n "$sdlconfig"&&  \
>> +   test "`basename $sdlconfig`" = sdl-config; then
> Instead of doing test -n "$sdlconfig" first with short-circuit
> evaluation, I think would should do:
>
> test $(basename "$sdlconfig") = sdl-config

$() is a bash-ism FYI.

Regards,

Anthony Liguori

> Then you don't need to test sdlconfig because basename will produce an
> empty string without error.
>
> Stefan
>

  parent reply	other threads:[~2011-04-08 20:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-08 16:33 [Qemu-devel] [PATCH] configure: avoid basename usage message Scott Wood
2011-04-08 18:56 ` Stefan Hajnoczi
2011-04-08 19:15   ` [Qemu-devel] [PATCH v2] " Scott Wood
2011-04-09 11:19     ` [Qemu-devel] " Stefan Hajnoczi
2011-04-08 20:06   ` Anthony Liguori [this message]
2011-04-08 20:20     ` [Qemu-devel] [PATCH] " Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D9F6AE1.1030808@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    --cc=scottwood@freescale.com \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.