From: Prashanth Bhat <prashanth.bhat@manipal.net>
To: mirq-linux@rere.qmqm.pl, adrian.hunter@nokia.com, cjb@laptop.org,
linux-mmc@vger.kernel.org, akpm@linux-foundation.org,
torvalds@linux-foundation.org
Subject: Potential Bug in drivers/mmc/
Date: Sat, 09 Apr 2011 07:04:42 +0530 [thread overview]
Message-ID: <4D9FB7B2.3080702@manipal.net> (raw)
Hi,
I'm new to Linux kernel code, but I think I spot a bug in a commit made
to drivers/mmc/core/bus.c in 2.6.36, back in Aug 2010.
Here's the GIT URL showing the changes in this commit:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=7310ece86ad7da027f85a37a0638164118a5d12f
At line 239, the following code change was made:
+ case MMC_TYPE_SD_COMBO:
+ type = "SD-combo";
+ if (mmc_card_blockaddr(card))
+ type = "SDHC-combo";
The bug : I would have expected to see a "break" at the end of the new
case entry. I don't see this, even in a later version of the source
(namely 2.6.38).
Please take a look, and also let me know what you decide.
Thanks,
Prashanth Bhat
=============================================================
Prashanth B. Bhat, Ph. D.
Chief Technology Officer,
Manipal Dot Net Pvt. Ltd.
Manipal 576 104 INDIA
http://www.linkedin.com/in/prashanthbhat
http://www.manipal.net
prashanth.bhat@manipal.net
=============================================================
reply other threads:[~2011-04-09 1:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9FB7B2.3080702@manipal.net \
--to=prashanth.bhat@manipal.net \
--cc=adrian.hunter@nokia.com \
--cc=akpm@linux-foundation.org \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.