From: Wen Congyang <wency@cn.fujitsu.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>,
Aurelien Jarno <aurelien@aurel32.net>,
qemu-devel <qemu-devel@nongnu.org>,
blauwirbel@gmail.com
Subject: [Qemu-devel] [PATCH] fix acpi regression
Date: Tue, 12 Apr 2011 13:13:15 +0800 [thread overview]
Message-ID: <4DA3DF6B.8010308@cn.fujitsu.com> (raw)
This bug is introduced by commit 23910d3f.
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
---
hw/acpi.c | 10 +++-------
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/hw/acpi.c b/hw/acpi.c
index e372474..790bd3b 100644
--- a/hw/acpi.c
+++ b/hw/acpi.c
@@ -355,7 +355,7 @@ static uint8_t *acpi_gpe_ioport_get_ptr(ACPIGPE *gpe, uint32_t addr)
if (addr < gpe->len / 2) {
cur = gpe->sts + addr;
} else if (addr < gpe->len) {
- cur = gpe->en + addr;
+ cur = gpe->en + addr - gpe->len / 2;
} else {
abort();
}
@@ -369,12 +369,8 @@ void acpi_gpe_ioport_writeb(ACPIGPE *gpe, uint32_t addr, uint32_t val)
addr -= gpe->blk;
cur = acpi_gpe_ioport_get_ptr(gpe, addr);
- if (addr < gpe->len / 2) {
- /* GPE_STS */
- *cur = (*cur) & ~val;
- } else if (addr < gpe->len) {
- /* GPE_EN */
- *cur = val;
+ if (cur != NULL) {
+ *cur = val & 0xff;
} else {
abort();
}
--
1.7.1
next reply other threads:[~2011-04-12 5:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 5:13 Wen Congyang [this message]
2011-04-12 8:48 ` [Qemu-devel] [PATCH] fix acpi regression Isaku Yamahata
2011-04-12 9:08 ` Wen Congyang
2011-04-12 9:20 ` Isaku Yamahata
2011-04-12 9:26 ` Wen Congyang
2011-04-12 9:27 ` [Qemu-devel] [PATCH V2] " Wen Congyang
2011-04-12 9:44 ` Isaku Yamahata
2011-04-12 21:35 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA3DF6B.8010308@cn.fujitsu.com \
--to=wency@cn.fujitsu.com \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.