From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58657) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9Zs0-0000bZ-DF for qemu-devel@nongnu.org; Tue, 12 Apr 2011 05:26:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q9Zry-0002J3-Km for qemu-devel@nongnu.org; Tue, 12 Apr 2011 05:26:48 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:34972) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q9Zry-0002IG-Ea for qemu-devel@nongnu.org; Tue, 12 Apr 2011 05:26:46 -0400 Message-ID: <4DA41ACB.8090403@siemens.com> Date: Tue, 12 Apr 2011 11:26:35 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1302597850-10708-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1302597850-10708-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: jan.kiszka@siemens.com Subject: Re: [Qemu-devel] [PATCH v3 0/4] Fix -icount with iothread List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 2011-04-12 10:44, Paolo Bonzini wrote: > This series finally fixes -icount with iothread and avoids deadlocks > due to the vm_clock not making progress when the VM is stopped. > The crux of the fix is in patch 1, while patch 2 implements the > "clock warping" that fixes deadlocks in v2. Clock warping uses > the nanosecond resolution rt_clock timers introduced by my previous > series. > > With this in place, patch 3 can revert the previous attempt(s). > Finally, patch 4 makes the icount code clearer by finishing the > bugfix/reorganization of qemu_next_deadline vs. qemu_next_alarm_deadline. > > v1->v2: > reordered patches, renamed qemu_next_deadline > > v2->v3: > introduced warp timer > > Paolo Bonzini (4): > really fix -icount in the iothread case > enable vm_clock to "warp" in the iothread+icount case > Revert wrong fixes for -icount in the iothread case > qemu_next_deadline should not consider host-time timers > > cpus.c | 13 ++++- > qemu-common.h | 1 + > qemu-timer.c | 145 ++++++++++++++++++++++++++++++++++++++++++--------------- > qemu-timer.h | 3 +- > 4 files changed, 121 insertions(+), 41 deletions(-) > On first glance, I've spotted a view coding style issues. Try checkpatch (maybe excluding patch 3). Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux