All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Yury Polyanskiy <ypolyans@princeton.edu>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] Notifier chain called twice
Date: Tue, 12 Apr 2011 14:39:55 +0400	[thread overview]
Message-ID: <4DA42BFB.2010908@mvista.com> (raw)
In-Reply-To: <BANLkTikTDQgwHtK1V4AqRAALw_HrSTuvnQ@mail.gmail.com>

Hello.

On 12-04-2011 10:44, Yury Polyanskiy wrote:

> Dear all,

> The notifier chain is currently called twice on OOPS. Patch below.

    You need to provide your signoff for the patch to be applied.

> Best,
> Yury

    The greeting and goodbye shouldn't be parts of the patch.

> diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
> index 4e00f9b..fdc6773 100644
> --- a/arch/mips/kernel/traps.c
> +++ b/arch/mips/kernel/traps.c
> @@ -375,8 +375,6 @@ void __noreturn die(const char *str, str
>          unsigned long dvpret = dvpe();
>   #endif /* CONFIG_MIPS_MT_SMTC */
>
> -       notify_die(DIE_OOPS, str, regs, 0, regs_to_trapnr(regs), SIGSEGV);
> -

    Unfortunately, the patch is whitespace-mangled: all tabs have been 
replaced by spaces.

WBR, Sergei

  reply	other threads:[~2011-04-12 10:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12  6:44 [PATCH] Notifier chain called twice Yury Polyanskiy
2011-04-12 10:39 ` Sergei Shtylyov [this message]
2011-05-12 12:50 ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DA42BFB.2010908@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ypolyans@princeton.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.