All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 4/4] qemu-timer: Fix timers for w32
Date: Tue, 12 Apr 2011 14:59:04 +0200	[thread overview]
Message-ID: <4DA44C98.7010302@siemens.com> (raw)
In-Reply-To: <4DA44832.3080206@redhat.com>

On 2011-04-12 14:40, Paolo Bonzini wrote:
> On 04/12/2011 02:36 PM, Jan Kiszka wrote:
>>> I see the same bug here with two XP hosts and also tried both timer
>>> variants
>>> of current QEMU (without a difference).
>>>
>>> I don't get the bug when running on a Linux host using wine.
>>
>> Passing no_timer_check to the Linux guest should work around the issue
>> as well. But this feature is only available since 2.6.20 (excluding
>> popular legacy 2.6.16 kernels).
> 
> I think adding back MM timers is fine, especially since a bug that only 
> happens under native Windows is a bug I'm unlikely to look at...

That wasn't meant as a vote against changing the Windows code paths,
just as a further hint how to work-around virtualization related effects.

Even with high-res timers, you may hit that issue once in a while, also
on Linux hosts. When using KVM, latest Linux guest will notice that they
are running on a hypervisor and should skip the test automatically IIRC.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

      reply	other threads:[~2011-04-12 12:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-10 18:28 [Qemu-devel] qemu-timer: Clean code and re-add multimedia timers for windows Stefan Weil
2011-04-10 18:28 ` [Qemu-devel] [PATCH 1/4] qemu-timer: Add and use new function qemu_timer_expired_ns Stefan Weil
2011-04-20 14:26   ` [Qemu-devel] [PULL] qemu-timer: Add and use new function qemu_timer_expired_ns and other patches Stefan Weil
2011-04-28 12:18     ` Stefan Weil
2011-04-29 21:09       ` Blue Swirl
2011-04-10 18:28 ` [Qemu-devel] [PATCH 2/4] qemu-timer: Remove unneeded include statement (w32) Stefan Weil
2011-04-10 18:28 ` [Qemu-devel] [PATCH 3/4] qemu-timer: Avoid type casts Stefan Weil
2011-04-10 18:28 ` [Qemu-devel] [PATCH 4/4] qemu-timer: Fix timers for w32 Stefan Weil
2011-04-11  7:36   ` [Qemu-devel] " Paolo Bonzini
2011-04-11 17:21     ` [Qemu-devel] " Stefan Weil
2011-04-12 12:36       ` Jan Kiszka
2011-04-12 12:40         ` Paolo Bonzini
2011-04-12 12:59           ` Jan Kiszka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DA44C98.7010302@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=aliguori@us.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.