Re: [PATCH -next reresend] i2c: designware-pcidrv depends on PCI

[Randy Dunlap <randy.dunlap@oracle.com>]

On 04/12/11 02:47, Jean Delvare wrote:
> Geert, Randy,
> 
> On Sat, 9 Apr 2011 13:34:49 +0200, Geert Uytterhoeven wrote:
>> On Fri, Apr 8, 2011 at 17:32, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>>
>>> i2c-designware-pcidrv is a PCI driver and should depend on PCI.
>>> Fixes these build errors:
>>>
>>> drivers/i2c/busses/i2c-designware-pcidrv.c:256: error: implicit declaration of function 'pci_request_region'
>>> drivers/i2c/busses/i2c-designware-pcidrv.c:338: error: implicit declaration of function 'pci_release_region'
>>>
>>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>>> Cc: Baruch Siach <baruch@tkos.co.il>
>>> ---
>>>  drivers/i2c/busses/Kconfig |    1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> Does anybody merge i2c patches???
>>
>> Yes please, it's been there since Mar 17, reported several times, and probably
>> masking other build failures.
> 
> This bug only exists in linux-next, as the code in question wasn't
> merged in Linus's tree yet. It is drawn into linux-next from Ben
> Dooks's next-i2c branch:
>   http://git.fluff.org/gitweb?p=bjdooks/linux.git;a=shortlog;h=refs/heads/next-i2c
> 
> This is where it has to be fixed, so only Ben can do it. Ben, please?
> 
> Meanwhile, it should be possible to apply a hot fix to linux-next
> directly, Stephen does it pretty often. Stephen, could you please apply
> this fix temporarily until Ben wakes up and applies it to his tree?

Thanks, Jean.

>>> --- linux-next-20110316.orig/drivers/i2c/busses/Kconfig
>>> +++ linux-next-20110316/drivers/i2c/busses/Kconfig
>>> @@ -359,6 +359,7 @@ config I2C_DESIGNWARE_PLATFORM
>>>
>>>  config I2C_DESIGNWARE_PCI
>>>        tristate "Synopsys DesignWare PCI"
>>> +       depends on PCI
>>>        help
>>>          If you say yes to this option, support will be included for the
>>>          Synopsys DesignWare I2C adapter. Only master mode is supported.
> 


-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***