From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Stefan Hajnoczi <stefanha@gmail.com>,
Markus Armbruster <armbru@redhat.com>,
qemu list <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 0/5] atapi: Implement 'media' subcommand for GESN
Date: Tue, 12 Apr 2011 18:09:29 +0200 [thread overview]
Message-ID: <4DA47939.1070908@redhat.com> (raw)
In-Reply-To: <cover.1302624272.git.amit.shah@redhat.com>
On 04/12/11 18:06, Amit Shah wrote:
> The GET_EVENT_STATUS_NOTIFICATION ATAPI command is listed as a
> mandatory command in the spec but we don't really implement it any of
> its sub-commands.
>
> The commit message for the last commit explains why implementing just
> the media subcommand is helpful and how it goes a long way in getting
> guests to behave as expected.
>
> The difference from the RFC series sent earlier is:
> - Split into more patches
> - Add tray open/close notification (from Markus)
>
> There certainly is much more work to be done for the other commands
> and also for state change handling (tray open / close / new media)
> overall for the block layer, but this is a good first step in being
> spec-compliant and at the same time making guests work.
>
v5 looks good.
Acked-by: Jes Sorensen <Jes.Sorensen@redhat.com>
Jes
next prev parent reply other threads:[~2011-04-12 16:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 16:06 [Qemu-devel] [PATCH v5 0/5] atapi: Implement 'media' subcommand for GESN Amit Shah
2011-04-12 16:06 ` [Qemu-devel] [PATCH v5 1/5] atapi: Allow GET_EVENT_STATUS_NOTIFICATION after media change Amit Shah
2011-04-12 16:06 ` [Qemu-devel] [PATCH v5 2/5] atapi: Move GET_EVENT_STATUS_NOTIFICATION command handling to its own function Amit Shah
2011-04-12 16:06 ` [Qemu-devel] [PATCH v5 3/5] atapi: GESN: Use structs for commonly-used field types Amit Shah
2011-04-12 16:06 ` [Qemu-devel] [PATCH v5 4/5] atapi: GESN: Standardise event response handling for future additions Amit Shah
2011-04-12 16:06 ` [Qemu-devel] [PATCH v5 5/5] atapi: GESN: implement 'media' subcommand Amit Shah
2011-04-12 16:09 ` Jes Sorensen [this message]
2011-04-12 16:29 ` [Qemu-devel] [PATCH v5 0/5] atapi: Implement 'media' subcommand for GESN Paolo Bonzini
2011-04-13 10:24 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA47939.1070908@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.