From: Hans de Goede <hdegoede@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] libcacard: fix opposite usage of isspace
Date: Wed, 13 Apr 2011 14:53:44 +0200 [thread overview]
Message-ID: <4DA59CD8.7040206@redhat.com> (raw)
In-Reply-To: <1302694920-8111-1-git-send-email-alevy@redhat.com>
This is the result of an of the list discussion with
me, and I can confirm this fixes the issues I was seeing:
Tested-by: Hans de Goede <hdegoede@redhat.com>
On 04/13/2011 01:42 PM, Alon Levy wrote:
> Signed-off-by: Alon Levy<alevy@redhat.com>
> ---
> libcacard/vcard_emul_nss.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libcacard/vcard_emul_nss.c b/libcacard/vcard_emul_nss.c
> index 71f2ba3..baada52 100644
> --- a/libcacard/vcard_emul_nss.c
> +++ b/libcacard/vcard_emul_nss.c
> @@ -955,7 +955,7 @@ count_tokens(const char *str, char token, char token_end)
> static const char *
> strip(const char *str)
> {
> - for (; *str&& !isspace(*str); str++) {
> + for (; *str&& isspace(*str); str++) {
> }
> return str;
> }
> @@ -963,7 +963,7 @@ strip(const char *str)
> static const char *
> find_blank(const char *str)
> {
> - for (; *str&& isspace(*str); str++) {
> + for (; *str&& !isspace(*str); str++) {
> }
> return str;
> }
next prev parent reply other threads:[~2011-04-13 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 11:42 [Qemu-devel] [PATCH] libcacard: fix opposite usage of isspace Alon Levy
2011-04-13 12:53 ` Hans de Goede [this message]
2011-04-18 19:18 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA59CD8.7040206@redhat.com \
--to=hdegoede@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.