From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] nestedhvm: ASID emulation (cleanup) Date: Wed, 13 Apr 2011 16:27:45 +0200 Message-ID: <4DA5B2E1.5000706@amd.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 04/13/11 15:28, Keir Fraser wrote: > On 13/04/2011 14:20, "Christoph Egger" wrote: > >> On Wednesday 13 April 2011 15:06:43 Keir Fraser wrote: >>> On 13/04/2011 11:35, "Christoph Egger" wrote: >>>> Cleanup for ASID emulation: >>>> - Use C99 integer types for asid numbers >>>> >>>> - asid.c: consistently use 'v' instead of 'curr' >>> >>> On what planet is that an improvement?? >>> >>> We use 'curr' as a convenient idiom to represent cached current. Whereas >>> 'v' is supposed to represent an arbitrary vcpu. >> >> Oh, that's the difference. I thought 'curr' is just another random name for an >> arbitrary vcpu. >> >> I will resend the patch w/o that hunk. > > I already applied the two cleanups that I didn't mind, as two separate > changesets. Thanks. > And I've nacked your main patch so you can go take a look at > that. :-) Just sent my comments. Christoph -- ---to satisfy European Law for business letters: Advanced Micro Devices GmbH Einsteinring 24, 85689 Dornach b. Muenchen Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632