From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:35259)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QARcE-0004eh-61
	for qemu-devel@nongnu.org; Thu, 14 Apr 2011 14:50:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QARcC-00031u-Hr
	for qemu-devel@nongnu.org; Thu, 14 Apr 2011 14:50:06 -0400
Received: from moutng.kundenserver.de ([212.227.17.10]:61070)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1QARcC-00030h-36
	for qemu-devel@nongnu.org; Thu, 14 Apr 2011 14:50:04 -0400
Message-ID: <4DA741D8.3020306@mail.berlios.de>
Date: Thu, 14 Apr 2011 20:50:00 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
References: <1302727085-14713-1-git-send-email-weil@mail.berlios.de>
	<BANLkTim_d=CWShjgsSn7hKNo5AYqCHZAAQ@mail.gmail.com>
In-Reply-To: <BANLkTim_d=CWShjgsSn7hKNo5AYqCHZAAQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Remove unneeded function parameter from
 gen_pc_load
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <http://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>

Am 13.04.2011 23:05, schrieb Peter Maydell:
> On 13 April 2011 21:38, Stefan Weil <weil@mail.berlios.de> wrote:
>> gen_pc_load was introduced in commit
>> d2856f1ad4c259e5766847c49acbb4e390731bd4.
>> The only reason for parameter searched_pc was
>> a debug statement in target-i386/translate.c.
>>
>> Remove searched_pc from the debug statement
>> and from the parameter list of gen_pc_load.
>
> No issues with the meat of the patch, but if we're going to
> change all the callers and implementations of this anyway,
> is there any appetite for giving it a more appropriate name?
> It doesn't generate any code, it affects more than just the
> pc, and it doesn't do a load...
>
> restore_state_to_opc() ? set_env_for_opc() ?
>
> -- PMM


What about cpu_restore_pc()? That's not always the whole truth,
but it's always the main action done in function n.n. which currently
is called gen_pc_load.

Or cpu_restore_helper()? Helper is very generic - it always fits.

Aurelien, please feel free to choose a name which suits bests.
I don't mind if you simply patch my patch, create a new one
or tell me which name should go into a new version of the patch
so I can send it.

Kind regards,
Stefan