All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vincent van Ravesteijn <vfr@lyx.org>
To: Git Mailing List <git@vger.kernel.org>
Cc: Jonathan Nieder <jrnieder@gmail.com>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH/resend] Documentation: update to git-merge-base --octopus
Date: Fri, 15 Apr 2011 10:43:53 +0200	[thread overview]
Message-ID: <4DA80549.5040600@lyx.org> (raw)
In-Reply-To: <20110412194558.GB1209@elie>

>> +When the option `--octopus` is given, the result of `git merge-base A B C`
>> > +will be '2', because '2' is the common ancestor of all branches.
> 
> Wouldn't it be easier to read if you had the option in the command line, i.e.
> 
>     The result of `git merge-base --octopus A B C` is '2' because...
> 
> without "When ... given" that now become noisewords?

Yes, that's much better. I included it in the rerolled patch series.

> Adding an example use of --octopus to the DISCUSSION section makes a
> lot of sense.  At first I thought this was being added to the
> DESCRIPTION section, which led me to suggest something like the
> following:
> 
> [..]
> 
> What do you think?

I like it, so I made a patch out of it and sent it to the list.

> For what it's worth, except for Junio's wording nitpick and the log message,
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks,

Vincent

  reply	other threads:[~2011-04-15  8:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-12 16:14 [PATCH/resend] Documentation: update to git-merge-base --octopus Vincent van Ravesteijn
2011-04-12 17:31 ` Junio C Hamano
2011-04-12 19:45 ` Jonathan Nieder
2011-04-15  8:43   ` Vincent van Ravesteijn [this message]
2011-04-15 17:18     ` Junio C Hamano
2011-04-15  8:34 ` [PATCH v2 1/2] " Vincent van Ravesteijn
2011-04-15  8:38 ` [PATCH 2/2] Restructure documentation for git-merge-base Vincent van Ravesteijn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DA80549.5040600@lyx.org \
    --to=vfr@lyx.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.