From: Christoph Egger <Christoph.Egger@amd.com>
To: ZhouPeng <zpengxen@gmail.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"ian.campbell@citrix.com" <ian.campbell@citrix.com>
Subject: Re: [PATCH]tools/libxl: fix a bug in libxl__build_device_model_args_new. info->vncpasswd can't be empty if info->vncpasswd != NULL
Date: Fri, 15 Apr 2011 11:37:57 +0200 [thread overview]
Message-ID: <4DA811F5.3080106@amd.com> (raw)
In-Reply-To: <BANLkTikKZOOfstWHCu_iD_JxsBmjx8HsxA@mail.gmail.com>
On 04/15/11 11:36, ZhouPeng wrote:
>
>
> 2011/4/15 Christoph Egger<Christoph.Egger@amd.com<mailto:Christoph.Egger@amd.com>>
> On 04/15/11 10:33, ZhouPeng wrote:
> Signed-off-by: Zhou Peng<zhoupeng@nfs.iscas.ac.cn<mailto:zhoupeng@nfs.iscas.ac.cn>>
>
> tools/libxl: fix a bug in libxl__build_device_model_args_new. info->vncpasswd can't be empty if info->vncpasswd != NULL
>
>
> NACK! This can info->vncpasswd[0] contains '\0' if you have
>
>
> vncpasswd=''
>
> in the guest config file.
>
> " if (info->vncpasswd&& info->vncpasswd[0]) “ can
> vncpasswd='' in guest cfg file, when using upstream-qemu-xen
> and block vncpasswd='passwd'
> Can it be reasonable?
>
Does that mean upstream qemu-xen and in-tree qemu-xen behave differently?
Christoph
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2011-04-15 9:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 8:33 [PATCH]tools/libxl: fix a bug in libxl__build_device_model_args_new. info->vncpasswd can't be empty if info->vncpasswd != NULL ZhouPeng
2011-04-15 8:28 ` Christoph Egger
2011-04-15 8:42 ` Ian Campbell
2011-04-15 9:36 ` ZhouPeng
2011-04-15 9:37 ` Christoph Egger [this message]
2011-04-15 9:53 ` ZhouPeng
2011-04-15 10:02 ` ZhouPeng
2011-04-18 15:06 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA811F5.3080106@amd.com \
--to=christoph.egger@amd.com \
--cc=ian.campbell@citrix.com \
--cc=xen-devel@lists.xensource.com \
--cc=zpengxen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.