From: Randy Dunlap <randy.dunlap@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: xfs build warning
Date: Fri, 15 Apr 2011 10:47:47 -0700 [thread overview]
Message-ID: <4DA884C3.9050207@oracle.com> (raw)
In-Reply-To: <20110415173902.GA27378@infradead.org>
On 04/15/11 10:39, Christoph Hellwig wrote:
> On Fri, Apr 15, 2011 at 09:48:02AM -0700, Randy Dunlap wrote:
>> on i386, when CONFIG_LBDAF is not enabled:
>>
>> fs/xfs/linux-2.6/./xfs_trace.h:1354: warning: format '%llx' expects type 'long long unsigned int', but argument 22 has type 'xfs_fsblock_t'
>
> This should fix it:
>
> Index: linux-2.6/fs/xfs/linux-2.6/xfs_trace.h
> ===================================================================
> --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_trace.h 2011-04-15 19:29:11.569340965 +0200
> +++ linux-2.6/fs/xfs/linux-2.6/xfs_trace.h 2011-04-15 19:30:09.679026159 +0200
> @@ -1418,7 +1418,7 @@ DECLARE_EVENT_CLASS(xfs_alloc_class,
> __entry->wasfromfl,
> __entry->isfl,
> __entry->userdata,
> - __entry->firstblock)
> + (unsigned long long)__entry->firstblock)
> )
>
> #define DEFINE_ALLOC_EVENT(name) \
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Thanks.
--
~Randy
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-04-15 17:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 16:48 xfs build warning Randy Dunlap
2011-04-15 17:39 ` Christoph Hellwig
2011-04-15 17:47 ` Randy Dunlap [this message]
2011-04-21 20:08 ` Alex Elder
2011-04-22 4:14 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA884C3.9050207@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.