From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch
Date: Sat, 16 Apr 2011 14:55:20 +0200 [thread overview]
Message-ID: <4DA991B8.1000105@aribaud.net> (raw)
In-Reply-To: <BANLkTi=JuAp6hccNxocEBYc44bq1vNB5Bw@mail.gmail.com>
Hi Macpaul Lin,
Le 16/04/2011 13:17, Macpaul Lin a ?crit :
> Hi all,
>
> 2011/4/16 Graeme Russ<graeme.russ@gmail.com>:
>> On 16/04/11 16:22, Albert ARIBAUD wrote:
>>>
>>> If the goal is to have the !defined aligned, then maybe a solution here
>>> would be toput a tab rather than a space after the #if?
>>>
>
> Do you guys means
> #if"\t"defined (XXXXXX) ||
> "\t"defined (XXXXXX)
> instead of
> #if defined (XXXXXX) ||
> "space*4" defined (XXXXXX)
> ?
Yes, this is what I mean.
> If so, I'll fix the patch and then send v2 on next Monday and see if
> everybody feel this will be better.
Amicalement,
--
Albert.
next prev parent reply other threads:[~2011-04-16 12:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 7:02 [U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch Macpaul Lin
2011-04-15 8:00 ` Mike Frysinger
2011-04-15 8:25 ` Macpaul Lin
2011-04-15 8:53 ` Mike Frysinger
2011-04-15 8:57 ` Macpaul Lin
2011-04-15 10:09 ` Wolfgang Denk
2011-04-15 10:18 ` Mike Frysinger
2011-04-16 6:18 ` Macpaul Lin
2011-04-16 6:35 ` Albert ARIBAUD
2011-04-16 6:22 ` Albert ARIBAUD
2011-04-16 7:07 ` Graeme Russ
2011-04-16 11:17 ` Macpaul Lin
2011-04-16 12:55 ` Albert ARIBAUD [this message]
2011-04-25 8:55 ` [U-Boot] [PATCH v2] " Macpaul Lin
2011-04-27 10:11 ` Detlev Zundel
2011-04-27 10:53 ` Macpaul Lin
2011-04-27 2:16 ` [U-Boot] [PATCH v3] " Macpaul Lin
2011-04-27 14:44 ` Detlev Zundel
2011-04-27 14:49 ` Macpaul Lin
2011-04-30 20:27 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA991B8.1000105@aribaud.net \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.