All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joshua Brindle <method@manicmethod.com>
To: Kohei KaiGai <kaigai@kaigai.gr.jp>
Cc: Kohei Kaigai <Kohei.Kaigai@EU.NEC.COM>,
	Eric Paris <eparis@redhat.com>,
	"selinux@tycho.nsa.gov" <selinux@tycho.nsa.gov>,
	"sds@tycho.nsa.gov" <sds@tycho.nsa.gov>
Subject: Re: [PATCH] selinux: revise /selinux/create to handle whitespace/multibytes correctly
Date: Sat, 16 Apr 2011 22:24:09 -0400	[thread overview]
Message-ID: <4DAA4F49.5050103@manicmethod.com> (raw)
In-Reply-To: <BANLkTi=ogbDZ8qjPNroumu=mbU2A6hU0XQ@mail.gmail.com>

Kohei KaiGai wrote:
> 2011/4/16 Joshua Brindle<method@manicmethod.com>:
>> Kohei KaiGai wrote:
>>> This patch allows to accept percent-encoded object name as the forth
>>> argument of /selinux/create interface to avoid possible bugs when we
>>> supply an object name that includes whitespace or multibytes.
>> Why not use standard bash escaping instead of html entities?
>>
> Does bash has a way to escape multibyte characters safety?
>
> Here are various number of multibyte encoding systems rather than unicode.
> For example, Japanese has three major encoding; EUC, JIS and Shift-JIS.
> If we try to use the code 0x5c ('\') as escape sequence, we may have
> possible trouble on the Shift-JIS environment, because it contains several
> characters that use 0x5c as second character.
>
> The bad news is Shift-JIS was the default encoding system delivered from
> MS-DOS, so it is still popular on Linux systems migrated from legacy ones. :-(
>
> Of course, we have many language support, I don't know what side effects
> may happen on a particular environment.
>
> So, it seems to me the assumption of percentage-encoding is enough
> conservative to deliver an object name from userspace to kernel.
>

Actually, this all seems moot since the current userspace labeling 
doesn't handle multibyte encoding.

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

  reply	other threads:[~2011-04-17  2:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-16 14:09 [PATCH] selinux: revise /selinux/create to handle whitespace/multibytes correctly Kohei KaiGai
2011-04-16 16:43 ` Joshua Brindle
2011-04-16 21:12   ` Kohei KaiGai
2011-04-17  2:24     ` Joshua Brindle [this message]
2011-04-17  7:18       ` Kohei KaiGai
2011-04-20 20:13 ` Eric Paris
2011-04-20 20:38   ` Kohei KaiGai
2011-05-03 14:10 ` Kohei KaiGai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DAA4F49.5050103@manicmethod.com \
    --to=method@manicmethod.com \
    --cc=Kohei.Kaigai@EU.NEC.COM \
    --cc=eparis@redhat.com \
    --cc=kaigai@kaigai.gr.jp \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.