From: Martin Peres <martin.peres-GANU6spQydw@public.gmane.org>
To: skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [PATCH] drm/nvc0/pm: read core/shader/memory clocks (more) correctly
Date: Mon, 18 Apr 2011 00:54:23 +0200 [thread overview]
Message-ID: <4DAB6F9F.3050905@free.fr> (raw)
In-Reply-To: <1303079563.13003.1.camel@nisroch>
Le 18/04/2011 00:32, Ben Skeggs a écrit :
> On Sun, 2011-04-17 at 17:10 +0200, Martin Peres wrote:
>> ---
>> drivers/gpu/drm/nouveau/nouveau_perf.c | 6 +++---
>> 1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/nouveau/nouveau_perf.c b/drivers/gpu/drm/nouveau/nouveau_perf.c
>> index 950caba..d64a98a 100644
>> --- a/drivers/gpu/drm/nouveau/nouveau_perf.c
>> +++ b/drivers/gpu/drm/nouveau/nouveau_perf.c
>> @@ -177,9 +177,9 @@ nouveau_perf_init(struct drm_device *dev)
>> #define subent(n) entry[perf[2] + ((n) * perf[3])]
>> perflvl->fanspeed = 0; /*XXX*/
>> perflvl->voltage = entry[2];
>> - perflvl->core = (ROM16(subent(0))& 0xfff) * 1000;
>> - perflvl->shader = (ROM16(subent(1))& 0xfff) * 1000;
>> - perflvl->memory = (ROM16(subent(2))& 0xfff) * 1000;
>> + perflvl->core = (ROM16(subent(3))& 0xfff) * 1000;
>> + perflvl->shader = (ROM16(subent(3))& 0xfff) / 2 * 1000;
>> + perflvl->memory = (ROM16(subent(5))& 0xfff) * 1000;
> Um, NACK. This is *definitely* very very wrong on NVA8, which uses
> version 0x40 of this table too.
>
> Ben.
Crap, I would have sworn this table was introduced for Fermi! Sorry for
the noise then, I'll try to find a fix for that (other than looking at
the codename).
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/nouveau
next prev parent reply other threads:[~2011-04-17 22:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-17 15:10 [PATCH] drm/nvc0/pm: read core/shader/memory clocks (more) correctly Martin Peres
[not found] ` <1303053035-25716-1-git-send-email-martin.peres-GANU6spQydw@public.gmane.org>
2011-04-17 22:32 ` Ben Skeggs
2011-04-17 22:54 ` Martin Peres [this message]
[not found] ` <4DAB6F9F.3050905-GANU6spQydw@public.gmane.org>
2011-04-17 22:56 ` Ben Skeggs
2011-04-17 23:05 ` Martin Peres
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAB6F9F.3050905@free.fr \
--to=martin.peres-ganu6spqydw@public.gmane.org \
--cc=nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
--cc=skeggsb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.