All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mohammed Shafi <mshajakhan@atheros.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Mohammed Shajakhan <Mohammed.Shajakhan@Atheros.com>,
	"linville@tuxdriver.com" <linville@tuxdriver.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"nbd@openwrt.org" <nbd@openwrt.org>,
	"helmut.schaa@googlemail.com" <helmut.schaa@googlemail.com>,
	Senthilkumar Balasubramanian
	<Senthilkumar.Balasubramanian@Atheros.com>
Subject: Re: [PATCH] {mac|nl}80211: Add station connected time
Date: Mon, 18 Apr 2011 09:47:09 +0530	[thread overview]
Message-ID: <4DABBB45.7090006@atheros.com> (raw)
In-Reply-To: <1302852596.3572.4.camel@jlt3.sipsolutions.net>

On Friday 15 April 2011 12:59 PM, Johannes Berg wrote:
> On Fri, 2011-04-08 at 21:24 +0530, Mohammed Shafi Shajakhan wrote:
>
>    
>> +static ssize_t sta_connected_time_read(struct file *file, char __user *userbuf,
>> +					size_t count, loff_t *ppos)
>> +{
>> +	struct sta_info *sta = file->private_data;
>> +	struct timespec uptime;
>> +	struct tm result;
>> +	long connected_time_secs;
>> +	char buf[100];
>> +	int res;
>> +	do_posix_clock_monotonic_gettime(&uptime);
>> +	connected_time_secs = uptime.tv_sec - sta->last_connected;
>> +	time_to_tm(connected_time_secs, 0,&result);
>> +	result.tm_year -= 70;
>> +	result.tm_mday -= 1;
>> +	res = scnprintf(buf, sizeof(buf),
>> +		"years  - %d\nmonths - %d\ndays   - %d\nclock  - %d:%d:%d\n\n",
>> +			result.tm_year, result.tm_mon, result.tm_mday,
>> +			result.tm_hour, result.tm_min, result.tm_sec);
>>      
> net/mac80211/debugfs_sta.c: In function 'sta_connected_time_read':
> net/mac80211/debugfs_sta.c:113:4: warning: format '%d' expects type
> 'int', but argument 4 has type 'long int'
>
> Please fix.
>    
Sure, thanks a lot.
> johannes
>
>    

      reply	other threads:[~2011-04-18  4:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-08 15:54 [PATCH] {mac|nl}80211: Add station connected time Mohammed Shafi Shajakhan
2011-04-15  7:29 ` Johannes Berg
2011-04-18  4:17   ` Mohammed Shafi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DABBB45.7090006@atheros.com \
    --to=mshajakhan@atheros.com \
    --cc=Mohammed.Shajakhan@Atheros.com \
    --cc=Senthilkumar.Balasubramanian@Atheros.com \
    --cc=helmut.schaa@googlemail.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=nbd@openwrt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.